Skip to content

Commit 34a5d5c

Browse files
committed
Add Alt+X keyboard shortcut to close the browser connection status bar
- when alt is pressed should show 'x' keycap on 'Hide' (status bar) ├── apps │ └── editor │ └── src │ └── views │ └── prompt │ └── frontend │ └── Main │ └── MainView │ ├── MainView.tsx │ ├── components │ │ └── BrowserConnectionStatus │ │ └── BrowserConnectionStatus.tsx │ └── hooks │ └── use-keyboard-shortcuts.ts └── packages └── ui └── src └── components └── editor └── prompt └── StatusBar └── StatusBar.tsx
1 parent b87892c commit 34a5d5c

3 files changed

Lines changed: 15 additions & 2 deletions

File tree

‎apps/editor/src/views/prompt/frontend/Main/MainView/MainView.tsx‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,18 +223,19 @@ export const MainView: React.FC<Props> = (props) => {
223223
cli_configurations: props.cli_configurations
224224
})
225225

226+
const browser_connection = use_browser_connection_status(props.is_connected)
227+
226228
const { is_alt_pressed } = use_keyboard_shortcuts({
227229
target: props.target,
228230
on_web_prompt_type_change: props.on_web_prompt_type_change,
229231
on_api_prompt_type_change: props.on_api_prompt_type_change,
230232
on_cli_prompt_type_change: props.on_cli_prompt_type_change,
231233
on_show_home: props.on_show_home,
232234
on_agentic_search: props.on_agentic_search,
235+
on_close_browser_connection: browser_connection.handle_close,
233236
is_disabled: props.are_keyboard_shortcuts_disabled
234237
})
235238

236-
const browser_connection = use_browser_connection_status(props.is_connected)
237-
238239
const web_configurations: UiConfigurations.Configuration[] =
239240
props.web_configurations.map((web_configuration, index) => {
240241
const is_unnamed =
@@ -374,6 +375,7 @@ export const MainView: React.FC<Props> = (props) => {
374375
is_visible={props.target == 'WEB'}
375376
is_connected={props.is_connected}
376377
is_closed={browser_connection.is_closed}
378+
is_alt_pressed={is_alt_pressed}
377379
on_close={browser_connection.handle_close}
378380
on_install={props.on_install_browser_extension}
379381
translations={{

‎apps/editor/src/views/prompt/frontend/Main/MainView/components/BrowserConnectionStatus/BrowserConnectionStatus.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ type Props = {
1414
}
1515
on_install: () => void
1616
on_close: () => void
17+
is_alt_pressed?: boolean
1718
}
1819

1920
export const BrowserConnectionStatus: React.FC<Props> = (props) => {
@@ -36,6 +37,7 @@ export const BrowserConnectionStatus: React.FC<Props> = (props) => {
3637
icon: 'codicon-close-small',
3738
label: props.translations.hide,
3839
title: props.translations.hide,
40+
keycap: props.is_alt_pressed ? 'X' : undefined,
3941
on_click: props.on_close
4042
})
4143
}

‎apps/editor/src/views/prompt/frontend/Main/MainView/hooks/use-keyboard-shortcuts.ts‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export const use_keyboard_shortcuts = (params: {
1313
on_cli_prompt_type_change: (prompt_type: CliPromptType) => void
1414
on_show_home: () => void
1515
on_agentic_search?: () => void
16+
on_close_browser_connection?: () => void
1617
is_disabled: boolean
1718
}) => {
1819
const [is_alt_pressed, set_is_alt_pressed] = useState(false)
@@ -152,6 +153,14 @@ export const use_keyboard_shortcuts = (params: {
152153
params.on_agentic_search?.()
153154
return
154155
}
156+
157+
if (event.code == 'KeyX') {
158+
if (params.target == 'WEB') {
159+
event.preventDefault()
160+
params.on_close_browser_connection?.()
161+
}
162+
return
163+
}
155164
}
156165

157166
window.addEventListener('keydown', handle_key_down)

0 commit comments

Comments
 (0)