Skip to content

Commit 3c560e7

Browse files
committed
Implement retry logic for API requests on 5xx errors and remove the 503 error message from the dictionary
1 parent 4f22ef5 commit 3c560e7

2 files changed

Lines changed: 35 additions & 14 deletions

File tree

‎apps/editor/src/utils/make-api-request.ts‎

Lines changed: 35 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -248,15 +248,42 @@ export const make_api_request = async (params: {
248248
: {})
249249
}
250250

251-
const response: AxiosResponse<NodeJS.ReadableStream> = await axios.post(
252-
request_url,
253-
request_body,
254-
{
255-
headers,
256-
cancelToken: params.cancellation_token,
257-
responseType: 'stream'
251+
let response: AxiosResponse<NodeJS.ReadableStream>
252+
let attempt = 0
253+
const MAX_RETRIES = 10
254+
const RETRY_DELAY_MS = 500
255+
256+
while (true) {
257+
try {
258+
response = await axios.post(request_url, request_body, {
259+
headers,
260+
cancelToken: params.cancellation_token,
261+
responseType: 'stream'
262+
})
263+
break
264+
} catch (error) {
265+
const status = axios.isAxiosError(error)
266+
? error.response?.status
267+
: undefined
268+
if (
269+
axios.isAxiosError(error) &&
270+
status &&
271+
status >= 500 &&
272+
status < 600 &&
273+
attempt < MAX_RETRIES
274+
) {
275+
attempt++
276+
Logger.warn({
277+
function_name: 'make_api_request',
278+
message: `API ${status} error encountered. Retrying (${attempt}/${MAX_RETRIES}) in 1s...`,
279+
data: error.message
280+
})
281+
await new Promise((resolve) => setTimeout(resolve, RETRY_DELAY_MS))
282+
} else {
283+
throw error
284+
}
258285
}
259-
)
286+
}
260287

261288
response.data.setEncoding('utf8')
262289

@@ -393,10 +420,6 @@ export const make_api_request = async (params: {
393420
)
394421
} else if (axios.isAxiosError(error) && error.response?.status == 400) {
395422
vscode.window.showErrorMessage(dictionary.error_message.API_BAD_REQUEST)
396-
} else if (axios.isAxiosError(error) && error.response?.status == 503) {
397-
vscode.window.showErrorMessage(
398-
dictionary.error_message.API_ENDPOINT_UNAVAILABLE
399-
)
400423
} else if (axios.isAxiosError(error) && error.response?.status == 401) {
401424
vscode.window.showErrorMessage(dictionary.error_message.API_INVALID_KEY)
402425
} else {

‎packages/shared/src/constants/dictionary.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -293,8 +293,6 @@ export const dictionary = {
293293
API_RATE_LIMIT_EXCEEDED: 'API request failed. Rate limit exceeded.',
294294
API_PAYLOAD_TOO_LARGE: 'API request failed. The context is too large.',
295295
API_BAD_REQUEST: 'API request failed. Bad request.',
296-
API_ENDPOINT_UNAVAILABLE:
297-
'Endpoint is currently unable to handle the request.',
298296
API_INVALID_KEY: 'API request failed. Invalid API key.',
299297
API_REQUEST_FAILED: 'API request failed. Check console for details.',
300298
FAILED_TO_CREATE_ITEM: (item_id: string, error: any) =>

0 commit comments

Comments
 (0)