Skip to content

Commit 55ec777

Browse files
committed
Update model dropdown to include an empty option and handle undefined model values properly
1 parent b3114eb commit 55ec777

1 file changed

Lines changed: 10 additions & 13 deletions

File tree

  • packages/vscode/src/views/panel/frontend/components/edit-preset-form/EditPresetForm

‎packages/vscode/src/views/panel/frontend/components/edit-preset-form/EditPresetForm/EditPresetForm.tsx‎

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,6 @@ export const EditPresetForm: React.FC<Props> = (props) => {
7272
[model, chatbot_config]
7373
)
7474

75-
useEffect(() => {
76-
if (!model && Object.keys(models).length > 0) {
77-
set_model(Object.keys(models)[0])
78-
}
79-
}, [model, models])
80-
8175
useEffect(() => {
8276
if (model_info) {
8377
const disabled = model_info.disabled_options || []
@@ -255,15 +249,18 @@ export const EditPresetForm: React.FC<Props> = (props) => {
255249
</Field>
256250
)}
257251

258-
{Object.keys(models).length > 0 && model && (
252+
{Object.keys(models).length > 0 && (
259253
<Field label="Model" html_for="model">
260254
<Dropdown
261-
options={Object.entries(models).map(([value, model_data]) => ({
262-
value,
263-
label: (model_data as any).label
264-
}))}
265-
value={model}
266-
onChange={set_model}
255+
options={[
256+
{ value: '', label: '—' },
257+
...Object.entries(models).map(([value, model_data]) => ({
258+
value,
259+
label: (model_data as any).label
260+
}))
261+
]}
262+
value={model || ''}
263+
onChange={(value) => set_model(value || undefined)}
267264
/>
268265
</Field>
269266
)}

0 commit comments

Comments
 (0)