Skip to content

Commit 8c53295

Browse files
committed
Rename review-related terminology to preview across the chat response application commands and related view components for consistency
1 parent 6e1c848 commit 8c53295

14 files changed

Lines changed: 187 additions & 188 deletions

File tree

‎packages/vscode/src/commands/apply-chat-response-command/apply-chat-response-command.ts‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import { get_diff_stats } from './utils/preview/diff-utils'
1414
import { create_safe_path } from '@/utils/path-sanitizer'
1515
import {
1616
preview_handler,
17-
ongoing_review_cleanup_promise
17+
ongoing_preview_cleanup_promise
1818
} from './utils/preview-handler'
1919
import { process_chat_response, CommandArgs } from './response-processor'
2020
import { Checkpoint } from '../checkpoints-command/types'
@@ -103,8 +103,8 @@ export const apply_chat_response_command = (params: {
103103
if (choice == 'Switch') {
104104
placeholder_created_at_for_update = new_item.created_at
105105
response_preview_promise_resolve({ accepted_files: [] })
106-
if (ongoing_review_cleanup_promise) {
107-
await ongoing_review_cleanup_promise
106+
if (ongoing_preview_cleanup_promise) {
107+
await ongoing_preview_cleanup_promise
108108
}
109109
await new Promise((r) => setTimeout(r, 500)) // Wait for all fileystem operation to finish
110110
} else {
@@ -145,14 +145,14 @@ export const apply_chat_response_command = (params: {
145145
args?.raw_instructions
146146
)
147147

148-
const review_data = await process_chat_response(
148+
const preview_data = await process_chat_response(
149149
args,
150150
chat_response,
151151
params.context,
152152
params.panel_provider
153153
)
154154

155-
if (review_data) {
155+
if (preview_data) {
156156
let created_at_for_preview = args?.created_at
157157
if (!args?.files_with_content) {
158158
let total_lines_added = 0
@@ -166,7 +166,7 @@ export const apply_chat_response_command = (params: {
166166
const default_workspace =
167167
vscode.workspace.workspaceFolders![0].uri.fsPath
168168

169-
for (const state of review_data.original_states) {
169+
for (const state of preview_data.original_states) {
170170
let workspace_root = default_workspace
171171
if (
172172
state.workspace_name &&
@@ -271,7 +271,7 @@ export const apply_chat_response_command = (params: {
271271
} else {
272272
created_at_for_preview = Date.now()
273273
const new_item: ResponseHistoryItem = {
274-
response: review_data.chat_response,
274+
response: preview_data.chat_response,
275275
raw_instructions: args?.raw_instructions,
276276
created_at: created_at_for_preview,
277277
lines_added: total_lines_added,
@@ -293,8 +293,8 @@ export const apply_chat_response_command = (params: {
293293
...params.panel_provider.response_history
294294
]
295295
const changes_accepted = await preview_handler({
296-
original_states: review_data.original_states,
297-
chat_response: review_data.chat_response,
296+
original_states: preview_data.original_states,
297+
chat_response: preview_data.chat_response,
298298
panel_provider: params.panel_provider,
299299
context: params.context,
300300
original_editor_state: args?.original_editor_state,

‎packages/vscode/src/commands/apply-chat-response-command/handlers/restore-preview-handler.ts‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export const handle_restore_preview = async (
1212
files: FileInPreview[]
1313
): Promise<{ success: boolean; original_states?: OriginalFileState[] }> => {
1414
Logger.info({
15-
function_name: 'handle_restore_review',
15+
function_name: 'handle_restore_preview',
1616
message: 'start',
1717
data: { file_count: files.length }
1818
})
@@ -25,7 +25,7 @@ export const handle_restore_preview = async (
2525
dictionary.error_message.NO_WORKSPACE_FOLDER_OPEN
2626
)
2727
Logger.warn({
28-
function_name: 'handle_restore_review',
28+
function_name: 'handle_restore_preview',
2929
message: 'No workspace folder open.'
3030
})
3131
return { success: false }
@@ -45,7 +45,7 @@ export const handle_restore_preview = async (
4545
workspace_root = workspace_map.get(file.workspace_name)!
4646
} else if (file.workspace_name) {
4747
Logger.warn({
48-
function_name: 'handle_restore_review',
48+
function_name: 'handle_restore_preview',
4949
message: `Workspace '${file.workspace_name}' not found for file '${file.file_path}'. Using default.`
5050
})
5151
}
@@ -54,7 +54,7 @@ export const handle_restore_preview = async (
5454

5555
if (!safe_path) {
5656
Logger.warn({
57-
function_name: 'handle_restore_review',
57+
function_name: 'handle_restore_preview',
5858
message: 'Unsafe file path detected and skipped',
5959
data: file.file_path
6060
})
@@ -69,7 +69,7 @@ export const handle_restore_preview = async (
6969
original_content = document.getText()
7070
} catch (e) {
7171
Logger.warn({
72-
function_name: 'handle_restore_review',
72+
function_name: 'handle_restore_preview',
7373
message: 'Could not read original content of file',
7474
data: { file_path: safe_path, error: e }
7575
})
@@ -112,7 +112,7 @@ export const handle_restore_preview = async (
112112

113113
fs.unlinkSync(safe_path)
114114
Logger.info({
115-
function_name: 'handle_restore_review',
115+
function_name: 'handle_restore_preview',
116116
message: 'File deleted',
117117
data: safe_path
118118
})
@@ -122,7 +122,7 @@ export const handle_restore_preview = async (
122122
})
123123
} catch (error) {
124124
Logger.error({
125-
function_name: 'handle_restore_review',
125+
function_name: 'handle_restore_preview',
126126
message: 'Error deleting file',
127127
data: { safe_path, error }
128128
})
@@ -156,13 +156,13 @@ export const handle_restore_preview = async (
156156

157157
await document.save()
158158
Logger.info({
159-
function_name: 'handle_restore_review',
159+
function_name: 'handle_restore_preview',
160160
message: 'Existing file replaced and saved',
161161
data: safe_path
162162
})
163163
} catch (error) {
164164
Logger.error({
165-
function_name: 'handle_restore_review',
165+
function_name: 'handle_restore_preview',
166166
message: 'Error updating file',
167167
data: { safe_path, error }
168168
})
@@ -176,13 +176,13 @@ export const handle_restore_preview = async (
176176
try {
177177
fs.mkdirSync(directory, { recursive: true })
178178
Logger.info({
179-
function_name: 'handle_restore_review',
179+
function_name: 'handle_restore_preview',
180180
message: 'Directory created',
181181
data: directory
182182
})
183183
} catch (error) {
184184
Logger.error({
185-
function_name: 'handle_restore_review',
185+
function_name: 'handle_restore_preview',
186186
message: 'Failed to create directory',
187187
data: { directory, error, file_path: file.file_path }
188188
})
@@ -198,15 +198,15 @@ export const handle_restore_preview = async (
198198
try {
199199
fs.writeFileSync(safe_path, file.content)
200200
Logger.info({
201-
function_name: 'handle_restore_review',
201+
function_name: 'handle_restore_preview',
202202
message: 'New file created',
203203
data: safe_path
204204
})
205205
const document = await vscode.workspace.openTextDocument(safe_path)
206206
await vscode.window.showTextDocument(document, { preview: false })
207207
} catch (error) {
208208
Logger.error({
209-
function_name: 'handle_restore_review',
209+
function_name: 'handle_restore_preview',
210210
message: 'Failed to write new file',
211211
data: { safe_path, error, file_path: file.file_path }
212212
})

‎packages/vscode/src/commands/apply-chat-response-command/response-processor.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,16 +51,16 @@ export const process_chat_response = async (
5151
const result = await handle_restore_preview(args.files_with_content)
5252
if (result.success && result.original_states) {
5353
const augmented_states = result.original_states.map((state) => {
54-
const file_in_review = args?.files_with_content!.find(
54+
const file_in_preview = args?.files_with_content!.find(
5555
(f) =>
5656
f.file_path === state.file_path &&
5757
f.workspace_name === state.workspace_name
5858
)
5959
return {
6060
...state,
6161
ai_content:
62-
file_in_review?.proposed_content ?? file_in_review?.content,
63-
is_checked: file_in_review?.is_checked
62+
file_in_preview?.proposed_content ?? file_in_preview?.content,
63+
is_checked: file_in_preview?.is_checked
6464
}
6565
})
6666
update_undo_button_state({

‎packages/vscode/src/commands/apply-chat-response-command/utils/preview-handler.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { preview } from './preview'
66
import { PanelProvider } from '@/views/panel/backend/panel-provider'
77
import { update_undo_button_state } from './state-manager'
88

9-
export let ongoing_review_cleanup_promise: Promise<void> | null = null
9+
export let ongoing_preview_cleanup_promise: Promise<void> | null = null
1010

1111
export const preview_handler = async (params: {
1212
original_states: OriginalFileState[]
@@ -21,7 +21,7 @@ export const preview_handler = async (params: {
2121
created_at?: number
2222
}): Promise<boolean> => {
2323
let resolve_cleanup_promise: () => void
24-
ongoing_review_cleanup_promise = new Promise((resolve) => {
24+
ongoing_preview_cleanup_promise = new Promise((resolve) => {
2525
resolve_cleanup_promise = resolve
2626
})
2727

@@ -66,7 +66,7 @@ export const preview_handler = async (params: {
6666
)
6767
} catch (error) {
6868
Logger.error({
69-
function_name: 'handle_code_review_and_cleanup',
69+
function_name: 'preview_handler',
7070
message: 'Error restoring original editor state',
7171
data: error
7272
})
@@ -155,6 +155,6 @@ export const preview_handler = async (params: {
155155
}
156156
} finally {
157157
resolve_cleanup_promise!()
158-
ongoing_review_cleanup_promise = null
158+
ongoing_preview_cleanup_promise = null
159159
}
160160
}

‎packages/vscode/src/commands/apply-chat-response-command/utils/preview/file-preparer.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import * as os from 'os'
66
import { OriginalFileState } from '@/commands/apply-chat-response-command/types/original-file-state'
77
import { create_safe_path } from '@/utils/path-sanitizer'
88
import { get_diff_stats } from './diff-utils'
9-
import { PreparedFile, ReviewableFile } from './types'
9+
import { PreparedFile, PreviewableFile } from './types'
1010

1111
export const prepare_files_from_original_states = async (params: {
1212
original_states: OriginalFileState[]
@@ -70,7 +70,7 @@ export const prepare_files_from_original_states = async (params: {
7070
current_content == '' &&
7171
state.content != '')
7272

73-
const reviewable_file: ReviewableFile = {
73+
const previewable_file: PreviewableFile = {
7474
type: 'file',
7575
file_path: state.file_path,
7676
content: current_content,
@@ -88,7 +88,7 @@ export const prepare_files_from_original_states = async (params: {
8888
}
8989

9090
prepared_files.push({
91-
reviewable_file,
91+
previewable_file,
9292
sanitized_path: sanitized_file_path,
9393
original_content: original_content_for_diff,
9494
temp_file_path,
@@ -121,7 +121,7 @@ export const prepare_files_from_original_states = async (params: {
121121
new_content: restored_current_content
122122
})
123123

124-
const restored_reviewable_file: ReviewableFile = {
124+
const restored_previewable_file: PreviewableFile = {
125125
type: 'file',
126126
file_path: state.file_path_to_restore,
127127
content: restored_current_content,
@@ -134,7 +134,7 @@ export const prepare_files_from_original_states = async (params: {
134134
}
135135

136136
prepared_files.push({
137-
reviewable_file: restored_reviewable_file,
137+
previewable_file: restored_previewable_file,
138138
sanitized_path: restored_sanitized_file_path,
139139
original_content: state.content,
140140
temp_file_path: restored_temp_file_path,

0 commit comments

Comments
 (0)