Skip to content

Commit a4460fa

Browse files
committed
Disable mark-as-complete action when prompt is empty and update prompt copy
- 'mark as complete' should be disabled without instructions - also don't show keycap on disabled checkbox ├── apps │ └── editor │ └── src │ └── views │ └── prompt │ └── frontend │ └── Main │ ├── Main.tsx │ └── MainView │ └── MainView.tsx └── packages └── ui └── src └── components └── editor └── common ├── Checkbox │ ├── Checkbox.module.scss │ └── Checkbox.tsx └── prompts └── PromptField ├── PromptField.tsx └── hooks └── use-keyboard-shortcuts.ts
1 parent c534139 commit a4460fa

4 files changed

Lines changed: 38 additions & 29 deletions

File tree

‎apps/editor/src/utils/prompt-builder.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ export namespace PromptBuilder {
9797
const tasks_str = params.completed_tasks
9898
.map((t) => `- [x] ${t}`)
9999
.join('\n')
100-
top_sys += `# Past task instructions\n\n${tasks_str}\n\n`
100+
top_sys += `# Past tasks\n\n${tasks_str}\n\n`
101101
}
102102
}
103103

@@ -164,8 +164,8 @@ export namespace PromptBuilder {
164164
const tasks_str = params.completed_tasks
165165
.map((t) => `- [x] ${t}`)
166166
.join('\n')
167-
part2 += `# Past task instructions\n\n${tasks_str}\n\n`
168-
full_prompt += `# Past task instructions\n\n${tasks_str}\n\n`
167+
part2 += `# Past tasks\n\n${tasks_str}\n\n`
168+
full_prompt += `# Past tasks\n\n${tasks_str}\n\n`
169169
}
170170

171171
if (part1.length > 0 || part2.length > 0 || full_prompt.length > 0) {

‎apps/editor/src/views/prompt/frontend/i18n/translations/prompt-field.ts‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -540,22 +540,22 @@ export const prompt_field = {
540540
bg: 'Затваряне на раздела'
541541
},
542542
'prompt-field.apply-from-terminal': {
543-
en: "Review agent's changes when ready",
544-
pl: 'Przejrzyj zmiany agenta, gdy będą gotowe',
545-
'zh-cn': '准备好后查看代理的更改',
546-
ja: '準備ができたらエージェントの変更を確認',
547-
'zh-tw': '準備好後查看代理的變更',
548-
de: 'Änderungen des Agenten prüfen, wenn bereit',
549-
es: 'Revisar los cambios del agente cuando esté listo',
550-
fr: "Examiner les modifications de l'agent lorsqu'elles sont prêtes",
551-
'pt-br': 'Revisar as alterações do agente quando estiver pronto',
552-
ru: 'Проверить изменения агента по готовности',
553-
ko: '준비되면 에이전트의 변경 사항 검토',
554-
it: "Esamina le modifiche dell'agente quando è pronto",
555-
tr: 'Hazır olduğunda ajanın değişikliklerini incele',
556-
cs: 'Zkontrolovat změny agenta, až budou připraveny',
557-
hu: 'Ügynök módosításainak ellenőrzése, ha kész',
558-
bg: 'Преглед на промените на агента, когато са готови'
543+
en: "Review agent's code when ready",
544+
pl: 'Przejrzyj kod agenta, gdy ten skończy pracę',
545+
'zh-cn': '准备好后审查代理的代码',
546+
ja: '準備ができたらエージェントのコードを確認',
547+
'zh-tw': '準備好後審查代理的程式碼',
548+
de: 'Code des Agenten überprüfen, sobald bereit',
549+
es: 'Revisar el código del agente cuando esté listo',
550+
fr: "Examiner le code de l'agent lorsqu'il est prêt",
551+
'pt-br': 'Revisar o código do agente quando estiver pronto',
552+
ru: 'Проверьте код агента, когда он будет готов',
553+
ko: '준비가 되면 에이전트의 코드 검토',
554+
it: "Rivedi il codice dell'agente quando è pronto",
555+
tr: 'Hazır olduğunda aracının kodunu incele',
556+
cs: 'Zkontrolujte kód agenta, až bude připraven',
557+
hu: 'Tekintse át az ügynök kódját, ha elkészült',
558+
bg: 'Прегледайте кода на агента, когато е готов'
559559
},
560560
'prompt-field.action.apply': {
561561
en: 'Apply',

‎packages/ui/src/components/editor/common/prompts/PromptField/PromptField.tsx‎

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -155,18 +155,17 @@ export const PromptField: React.FC<PromptField.Props> = (props) => {
155155
const [is_checkbox_hovered, set_is_checkbox_hovered] = useState(false)
156156
const [is_completed_tasks_expanded, set_is_completed_tasks_expanded] =
157157
useState(false)
158+
const { is_alt_pressed, is_left_alt_pressed_ref, handle_container_key_down } =
159+
use_keyboard_shortcuts(props)
158160

159161
const container_inner_ref = useRef<HTMLDivElement>(null)
160162
const tabs_ref = useRef<TabsRef>(null)
161-
163+
const is_mark_as_complete_disabled = !props.value.trim()
162164
const has_content =
163165
!!props.value ||
164166
!!(props.selected_files && props.selected_files.length > 0) ||
165167
props.completed_tasks.length > 0
166168

167-
const { is_alt_pressed, is_left_alt_pressed_ref, handle_container_key_down } =
168-
use_keyboard_shortcuts(props)
169-
170169
const {
171170
is_dropdown_open,
172171
toggle_dropdown,
@@ -346,12 +345,20 @@ export const PromptField: React.FC<PromptField.Props> = (props) => {
346345
className={styles['checkbox-wrapper']}
347346
style={{ visibility: 'hidden' }}
348347
>
349-
{is_alt_pressed ? (
348+
{is_alt_pressed && !is_mark_as_complete_disabled ? (
350349
<KeycapWrapper char="C">
351-
<Checkbox checked={false} on_change={() => {}} />
350+
<Checkbox
351+
checked={false}
352+
disabled={is_mark_as_complete_disabled}
353+
on_change={() => {}}
354+
/>
352355
</KeycapWrapper>
353356
) : (
354-
<Checkbox checked={false} on_change={() => {}} />
357+
<Checkbox
358+
checked={false}
359+
disabled={is_mark_as_complete_disabled}
360+
on_change={() => {}}
361+
/>
355362
)}
356363
</div>
357364
)}
@@ -391,17 +398,18 @@ export const PromptField: React.FC<PromptField.Props> = (props) => {
391398
onMouseEnter={() => set_is_checkbox_hovered(true)}
392399
onMouseLeave={() => set_is_checkbox_hovered(false)}
393400
>
394-
{is_checkbox_hovered && (
401+
{is_checkbox_hovered && !is_mark_as_complete_disabled && (
395402
<Tooltip
396403
message={props.translations.mark_as_complete}
397404
position="right"
398405
align="center"
399406
/>
400407
)}
401-
{is_alt_pressed ? (
408+
{is_alt_pressed && !is_mark_as_complete_disabled ? (
402409
<KeycapWrapper char="C">
403410
<Checkbox
404411
checked={false}
412+
disabled={is_mark_as_complete_disabled}
405413
on_change={() => {
406414
props.on_task_completed!()
407415
}}
@@ -410,6 +418,7 @@ export const PromptField: React.FC<PromptField.Props> = (props) => {
410418
) : (
411419
<Checkbox
412420
checked={false}
421+
disabled={is_mark_as_complete_disabled}
413422
on_change={() => {
414423
props.on_task_completed!()
415424
}}

‎packages/ui/src/components/editor/common/prompts/PromptField/hooks/use-keyboard-shortcuts.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ export const use_keyboard_shortcuts = (props: PromptField.Props) => {
333333
!e.metaKey &&
334334
!e.shiftKey
335335
) {
336-
if (props.on_task_completed) {
336+
if (props.on_task_completed && props.value.trim()) {
337337
e.stopPropagation()
338338
e.preventDefault()
339339
props.on_task_completed()

0 commit comments

Comments
 (0)