Skip to content

Commit c81dc74

Browse files
committed
Encapsulate agent search output channel creation and disposal within perform agent search mode
- ERROR in ./src/utils/git-repository-utils.ts:461:52 TS2345: Argument of type '{ get_files: () => Promise<any[]>; workspace_provider: WorkspaceProvider; extension_context: vscode.ExtensionContext; websocket_manager: WebSocketManager; show_back_button: true; }' is not assignable to parameter of type '{ get_files: () => Promise<string[]>; workspace_provider: WorkspaceProvider; extension_context: ExtensionContext; websocket_manager: WebSocketManager; ... 5 more ...; is_workspace_action?: boolean | undefined; }'. Property 'output_channel' is missing in type '{ get_files: () => Promise<any[]>; workspace_provider: WorkspaceProvider; extension_context: vscode.ExtensionContext; websocket_manager: WebSocketManager; show_back_button: true; }' but required in type '{ get_files: () => Promise<string[]>; workspace_provider: WorkspaceProvider; extension_context: ExtensionContext; websocket_manager: WebSocketManager; ... 5 more ...; is_workspace_action?: boolean | undefined; }'. 459 | ... - create output channel deeper, in 'perform agent search' └── apps └── editor └── src ├── commands │ ├── search-files-commands │ │ ├── index.ts │ │ ├── search-files-commands.ts │ │ └── utils │ │ ├── get-target-folder-path.ts │ │ └── prompt-for-provided-results.ts │ ├── select-clipboard-paths-command.ts │ ├── select-files-of-commit-command.ts │ ├── select-imported-files-commands │ │ └── utils │ │ └── prompt-for-imported-files.ts │ ├── select-modified-files-command.ts │ └── select-referencing-files-commands │ └── utils │ └── prompt-for-referencing-files.ts ├── features │ └── search-files │ ├── index.ts │ ├── search-files.ts │ ├── search-modes │ │ ├── perform-agent-search-mode │ │ │ ├── agents │ │ │ │ ├── antigravity.ts │ │ │ │ ├── claude.ts │ │ │ │ ├── codex.ts │ │ │ │ ├── cursor.ts │ │ │ │ ├── grok.ts │ │ │ │ ├── muse.ts │ │ │ │ └── opencode.ts │ │ │ ├── index.ts │ │ │ ├── perform-agent-search-mode.ts │ │ │ ├── types.ts │ │ │ └── utils.ts │ │ ├── perform-intelligent-search-mode.ts │ │ ├── perform-keywords-search-mode.ts │ │ └── perform-phrase-search-mode.ts │ └── utils │ ├── analyze-files.ts │ ├── check-matches-condition.ts │ ├── create-search-regex.ts │ ├── group-quick-pick-items.ts │ ├── handle-parent-folder-result.ts │ ├── map-files-to-quick-pick-items.ts │ ├── prompt-for-config.ts │ ├── prompt-for-intelligent-search-results.ts │ ├── prompt-for-keywords-match-mode.ts │ ├── prompt-for-keywords-target.ts │ ├── prompt-for-search-mode.ts │ ├── prompt-for-search-results.ts │ ├── prompt-for-search-term.ts │ ├── prompt-for-shrink-mode.ts │ ├── search-files-by-intelligent.ts │ ├── search-files-by-keywords.ts │ ├── search-files-by-phrase.ts │ └── show-search-results-quick-pick.ts └── utils └── git-repository-utils.ts
1 parent 3c0fb2d commit c81dc74

3 files changed

Lines changed: 598 additions & 588 deletions

File tree

‎apps/editor/src/commands/search-files-commands/search-files-commands.ts‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,6 @@ export const search_files_commands = (
123123
return
124124
}
125125
search_in_progress = true
126-
const output_channel =
127-
vscode.window.createOutputChannel('CWC Agentic Search')
128126
try {
129127
if (options?.provided_files) {
130128
let resolved_all_files: string[] = []
@@ -182,7 +180,6 @@ export const search_files_commands = (
182180
workspace_provider,
183181
extension_context,
184182
websocket_manager,
185-
output_channel,
186183
show_back_button: true,
187184
is_sub_search: true
188185
})
@@ -240,7 +237,6 @@ export const search_files_commands = (
240237
workspace_provider,
241238
extension_context,
242239
websocket_manager,
243-
output_channel,
244240
folder_path,
245241
is_workspace_action: options?.is_workspace_action
246242
})
@@ -259,7 +255,6 @@ export const search_files_commands = (
259255
}
260256
} finally {
261257
search_in_progress = false
262-
output_channel.dispose()
263258
}
264259
}
265260

@@ -271,7 +266,6 @@ export const search_files_commands = (
271266
return
272267
}
273268
search_in_progress = true
274-
const output_channel = vscode.window.createOutputChannel('Code Web Chat')
275269
try {
276270
const currently_checked = workspace_provider.get_checked_files()
277271
if (currently_checked.length === 0) {
@@ -306,7 +300,6 @@ export const search_files_commands = (
306300
workspace_provider,
307301
extension_context,
308302
websocket_manager,
309-
output_channel,
310303
is_search_in_selected: true,
311304
folder_path
312305
})
@@ -326,7 +319,6 @@ export const search_files_commands = (
326319
}
327320
} finally {
328321
search_in_progress = false
329-
output_channel.dispose()
330322
}
331323
}
332324

‎apps/editor/src/features/search-files/search-files.ts‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ export const search_files = async (params: {
1515
workspace_provider: WorkspaceProvider
1616
extension_context: vscode.ExtensionContext
1717
websocket_manager: WebSocketManager
18-
output_channel: vscode.OutputChannel
1918
show_back_button?: boolean
2019
is_sub_search?: boolean
2120
is_search_in_selected?: boolean
@@ -45,7 +44,6 @@ export const search_files = async (params: {
4544
workspace_provider: params.workspace_provider,
4645
extension_context: params.extension_context,
4746
websocket_manager: params.websocket_manager,
48-
output_channel: params.output_channel,
4947
show_back_button: true,
5048
is_sub_search: true,
5149
is_search_in_selected: params.is_search_in_selected,
@@ -109,7 +107,6 @@ export const search_files = async (params: {
109107
resolve_files,
110108
workspace_provider: params.workspace_provider,
111109
extension_context: params.extension_context,
112-
output_channel: params.output_channel,
113110
show_back_button: params.show_back_button,
114111
search_in_results,
115112
is_search_in_selected: params.is_search_in_selected,

0 commit comments

Comments
 (0)