Skip to content

Commit d13f5e1

Browse files
committed
Refine installer output messages and remove trailing completion text
- installing is very fast, these should be consolidated: [Pasted text] into a single sucess line
1 parent 508f223 commit d13f5e1

2 files changed

Lines changed: 4 additions & 7 deletions

File tree

‎install.ps1‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,11 @@ if (!$vsixFile) {
9494
function Install-ToEditor($idx) {
9595
$editorName = $availableEditors[$idx]
9696
$editorCmd = $editorCmds[$idx]
97-
Write-Host "Installing to $editorName..."
9897
& $editorCmd --install-extension $vsixFile.FullName --force *>$null
98+
Write-Host "Successfully installed to $editorName!"
9999
}
100100

101+
Write-Host ""
101102
if ($choice -eq 'a' -or $choice -eq 'A') {
102103
for ($i = 0; $i -lt $availableEditors.Count; $i++) {
103104
Install-ToEditor $i
@@ -106,8 +107,6 @@ if ($choice -eq 'a' -or $choice -eq 'A') {
106107
Install-ToEditor ([int]$choice - 1)
107108
}
108109

109-
Write-Host "`nDone!"
110-
111110
Pause
112111
Pop-Location
113112
# Run cleanup in the background to avoid sluggish exit

‎install.sh‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,17 +122,15 @@ install_to_editor() {
122122
local idx=$1
123123
local editor_name="${AVAILABLE_EDITORS[$idx]}"
124124
local editor_cmd="${EDITOR_CMDS[$idx]}"
125-
echo "Installing to $editor_name..."
126125
$editor_cmd --install-extension "$VSIX_FILE" --force > /dev/null 2>&1
126+
echo "Successfully installed to $editor_name!"
127127
}
128128

129+
echo ""
129130
if [[ "$choice" == "a" || "$choice" == "A" ]]; then
130131
for i in "${!AVAILABLE_EDITORS[@]}"; do
131132
install_to_editor $i
132133
done
133134
else
134135
install_to_editor $((choice-1))
135136
fi
136-
137-
echo ""
138-
echo "Done!"

0 commit comments

Comments
 (0)