Skip to content

Commit d88e009

Browse files
committed
Replace IconButton with codicon span for template group header chevron
- in Templates, don't use icon button, just plainly use chevron icon ├── apps │ └── editor │ └── src │ └── views │ └── settings │ └── frontend │ └── Home │ └── sections │ └── GeneralSection.tsx └── packages └── ui └── src ├── components │ └── editor │ ├── common │ │ └── IconButton │ │ ├── IconButton.module.scss │ │ └── IconButton.tsx │ └── settings-view │ ├── Item │ │ ├── Item.module.scss │ │ └── Item.tsx │ └── Templates │ ├── Templates.module.scss │ └── Templates.tsx └── styles └── foundation └── _colors.scss
1 parent 298f825 commit d88e009

2 files changed

Lines changed: 6 additions & 12 deletions

File tree

‎packages/ui/src/components/editor/settings-view/Templates/Templates.module.scss‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
display: flex;
5252
align-items: center;
5353
justify-content: space-between;
54-
padding: 8px 12px;
54+
padding: 8px 14px 8px 12px;
5555
cursor: pointer;
5656
user-select: none;
5757

‎packages/ui/src/components/editor/settings-view/Templates/Templates.tsx‎

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -81,17 +81,11 @@ export const Templates: React.FC<Templates.Props> = (props) => {
8181
)}
8282
<span className={styles.group__label}>{label}</span>
8383
</div>
84-
<IconButton
85-
codicon_icon={is_expanded ? 'chevron-up' : 'chevron-down'}
86-
title={
87-
is_expanded
88-
? props.translations.collapse
89-
: props.translations.expand
90-
}
91-
on_click={(e) => {
92-
e.stopPropagation()
93-
toggle_expanded(key)
94-
}}
84+
<span
85+
className={cn(
86+
'codicon',
87+
is_expanded ? 'codicon-chevron-up' : 'codicon-chevron-down'
88+
)}
9589
/>
9690
</div>
9791

0 commit comments

Comments
 (0)