Skip to content

Commit df9ba57

Browse files
committed
Update API manager modal to always show elapsed time and remove show_elapsed_time flag
1 parent 6251503 commit df9ba57

5 files changed

Lines changed: 20 additions & 70 deletions

File tree

‎apps/editor/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@
127127
"command": "codeWebChat.rate",
128128
"title": "Rate",
129129
"category": "Code Web Chat",
130-
"icon": "$(feedback)"
130+
"icon": "$(star-empty)"
131131
},
132132
{
133133
"command": "codeWebChat.openRepository",
@@ -621,7 +621,7 @@
621621
{
622622
"command": "codeWebChat.rate",
623623
"when": "view == codeWebChatView",
624-
"group": "navigation@1.5"
624+
"group": "navigation@3"
625625
},
626626
{
627627
"command": "codeWebChat.openRepository",

‎apps/editor/src/views/panel/frontend/hooks/use-modal-manager.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ export const use_modal_manager = () => {
5757
tokens_per_second: message.tokens_per_second,
5858
total_tokens: message.total_tokens,
5959
cancellable: message.cancellable ?? true,
60-
show_elapsed_time: message.show_elapsed_time,
6160
delay_visibility: message.delay_visibility,
6261
provider_name: message.provider_name,
6362
model: message.model,

‎apps/editor/src/views/panel/types/messages.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -820,7 +820,6 @@ export interface ShowApiManagerProgressMessage extends BaseMessage {
820820
tokens_per_second?: number
821821
total_tokens?: number
822822
cancellable?: boolean
823-
show_elapsed_time?: boolean
824823
delay_visibility?: boolean
825824
provider_name: string
826825
model?: string

‎packages/ui/src/components/editor/panel/modals/ApiManagerModal/ApiManagerModal.stories.tsx‎

Lines changed: 17 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ export const Default = () => {
1010
{
1111
id: '1',
1212
title: 'Receiving...',
13-
show_elapsed_time: true,
1413
provider_name: 'OpenAI',
1514
model: 'gpt-5.2'
1615
}
@@ -29,7 +28,6 @@ export const Default = () => {
2928
{
3029
id: '1',
3130
title: 'Receiving...',
32-
show_elapsed_time: true,
3331
provider_name: 'OpenAI',
3432
model: 'gpt-5.2'
3533
}
@@ -42,11 +40,10 @@ export const Default = () => {
4240
}
4341

4442
export const MultipleItems = () => {
45-
const [items, set_items] = useState([
43+
const initial_items = [
4644
{
4745
id: '1',
4846
title: 'Thinking...',
49-
show_elapsed_time: true,
5047
provider_name: 'OpenAI',
5148
model: 'gpt-5.2'
5249
},
@@ -55,110 +52,98 @@ export const MultipleItems = () => {
5552
title: 'Receiving...',
5653
tokens_per_second: 145,
5754
total_tokens: 320,
58-
show_elapsed_time: true,
5955
provider_name: 'OpenAI',
6056
model: 'gpt-5.2'
6157
},
6258
{
6359
id: '3',
6460
title: 'Waiting for connection...',
65-
show_elapsed_time: true,
6661
provider_name: 'Anthropic',
6762
model: 'claude-4-5-sonnet'
6863
},
6964
{
70-
id: '1',
65+
id: '4',
7166
title: 'Thinking...',
72-
show_elapsed_time: true,
7367
provider_name: 'OpenAI',
7468
model: 'gpt-5.2'
7569
},
7670
{
77-
id: '2',
71+
id: '5',
7872
title: 'Receiving...',
7973
tokens_per_second: 145,
8074
total_tokens: 320,
81-
show_elapsed_time: true,
8275
provider_name: 'OpenAI',
8376
model: 'gpt-5.2'
8477
},
8578
{
86-
id: '3',
79+
id: '6',
8780
title: 'Waiting for connection...',
88-
show_elapsed_time: true,
8981
provider_name: 'OpenAI',
9082
model: 'gpt-5.2'
9183
},
9284
{
93-
id: '1',
85+
id: '7',
9486
title: 'Thinking...',
95-
show_elapsed_time: true,
9687
provider_name: 'OpenAI',
9788
model: 'gpt-5.2'
9889
},
9990
{
100-
id: '2',
91+
id: '8',
10192
title: 'Receiving...',
10293
tokens_per_second: 145,
10394
total_tokens: 320,
104-
show_elapsed_time: true,
10595
provider_name: 'OpenAI',
10696
model: 'gpt-5.2'
10797
},
10898
{
109-
id: '3',
99+
id: '9',
110100
title: 'Waiting for connection...',
111-
show_elapsed_time: true,
112101
provider_name: 'OpenAI',
113102
model: 'gpt-5.2'
114103
},
115104
{
116-
id: '1',
105+
id: '10',
117106
title: 'Thinking...',
118-
show_elapsed_time: true,
119107
provider_name: 'OpenAI',
120108
model: 'gpt-5.2'
121109
},
122110
{
123-
id: '2',
111+
id: '11',
124112
title: 'Receiving...',
125113
tokens_per_second: 145,
126114
total_tokens: 320,
127-
show_elapsed_time: true,
128115
provider_name: 'OpenAI',
129116
model: 'gpt-5.2'
130117
},
131118
{
132-
id: '3',
119+
id: '12',
133120
title: 'Waiting for connection...',
134-
show_elapsed_time: true,
135121
provider_name: 'OpenAI',
136122
model: 'gpt-5.2'
137123
},
138124
{
139-
id: '1',
125+
id: '13',
140126
title: 'Thinking...',
141-
show_elapsed_time: true,
142127
provider_name: 'OpenAI',
143128
model: 'gpt-5.2'
144129
},
145130
{
146-
id: '2',
131+
id: '14',
147132
title: 'Receiving...',
148133
tokens_per_second: 145,
149134
total_tokens: 320,
150-
show_elapsed_time: true,
151135
provider_name: 'OpenAI',
152136
model: 'gpt-5.2'
153137
},
154138
{
155-
id: '3',
139+
id: '15',
156140
title: 'Waiting for connection...',
157-
show_elapsed_time: true,
158141
provider_name: 'OpenAI',
159142
model: 'gpt-5.2'
160143
}
161-
])
144+
]
145+
146+
const [items, set_items] = useState(initial_items)
162147

163148
const handle_cancel = (id: string) => {
164149
set_items((prev) => prev.filter((i) => i.id !== id))
@@ -167,36 +152,6 @@ export const MultipleItems = () => {
167152
return items.length > 0 ? (
168153
<ApiManagerModal progress_items={items} on_cancel={handle_cancel} />
169154
) : (
170-
<button
171-
onClick={() =>
172-
set_items([
173-
{
174-
id: '1',
175-
title: 'Thinking...',
176-
show_elapsed_time: true,
177-
provider_name: 'OpenAI',
178-
model: 'gpt-5.2'
179-
},
180-
{
181-
id: '2',
182-
title: 'Receiving...',
183-
tokens_per_second: 145,
184-
total_tokens: 320,
185-
show_elapsed_time: true,
186-
provider_name: 'OpenAI',
187-
model: 'gpt-5.2'
188-
},
189-
{
190-
id: '3',
191-
title: 'Waiting for connection...',
192-
show_elapsed_time: true,
193-
provider_name: 'OpenAI',
194-
model: 'gpt-5.2'
195-
}
196-
])
197-
}
198-
>
199-
Reset
200-
</button>
155+
<button onClick={() => set_items(initial_items)}>Reset</button>
201156
)
202157
}

‎packages/ui/src/components/editor/panel/modals/ApiManagerModal/ApiManagerModal.tsx‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ type Props = {
99
title: string
1010
tokens_per_second?: number
1111
total_tokens?: number
12-
show_elapsed_time?: boolean
1312
delay_visibility?: boolean
1413
provider_name: string
1514
model?: string
@@ -151,9 +150,7 @@ export const ApiManagerModal: React.FC<Props> = (props) => {
151150
{item.total_tokens !== undefined && (
152151
<div>({format_tokens(item.total_tokens)})</div>
153152
)}
154-
{item.show_elapsed_time && (
155-
<div>{(elapsed_ms / 1000).toFixed(1)}s</div>
156-
)}
153+
<div>{(elapsed_ms / 1000).toFixed(1)}s</div>
157154
</div>
158155
</div>
159156
</div>

0 commit comments

Comments
 (0)