test: split the coverage walk to settle Codacy's PMD findings

`visit` and `checkRange` exceeded PMD's NPath threshold of 200, so the
container walk and the parent check move into methods of their own.
`isHeld` compares with `==` on purpose: a getter that answers a new
object on every call computes its child rather than holding it.

Author: knutwannheden

src/test/java/net/sf/jsqlparser/parser/ASTNodeCoverageTest.java

@@ -207,27 +207,31 @@ private void visit(Object value, int[] enclosing) {
                 checkRange(value, range, enclosing);
             }
             int[] inner = range != null ? range : enclosing;
+            visitElements(value, inner);
+            if (isModel(value)) {
+                for (Method getter : value.getClass().getMethods()) {
+                    if (isChildGetter(getter)) {
+                        visitChild(value, getter, inner);
+                    }
+                }
+            }
+        }
+
+        private void visitElements(Object value, int[] enclosing) {
             if (value instanceof Collection) {
                 for (Object element : (Collection<?>) value) {
-                    visit(element, inner);
+                    visit(element, enclosing);
                 }
             } else if (value instanceof Map) {
                 for (Map.Entry<?, ?> entry : ((Map<?, ?>) value).entrySet()) {
-                    visit(entry.getKey(), inner);
-                    visit(entry.getValue(), inner);
+                    visit(entry.getKey(), enclosing);
+                    visit(entry.getValue(), enclosing);
                 }
             } else if (value instanceof Map.Entry) {
-                visit(((Map.Entry<?, ?>) value).getKey(), inner);
-                visit(((Map.Entry<?, ?>) value).getValue(), inner);
+                visit(((Map.Entry<?, ?>) value).getKey(), enclosing);
+                visit(((Map.Entry<?, ?>) value).getValue(), enclosing);
             } else if (value instanceof Optional) {
-                ((Optional<?>) value).ifPresent(present -> visit(present, inner));
-            }
-            if (isModel(value)) {
-                for (Method getter : value.getClass().getMethods()) {
-                    if (isChildGetter(getter)) {
-                        visitChild(value, getter, inner);
-                    }
-                }
+                ((Optional<?>) value).ifPresent(present -> visit(present, enclosing));
             }
         }
 
@@ -271,14 +275,7 @@ private void checkRange(Object value, int[] range, int[] enclosing) {
             if (enclosing != null && (range[0] < enclosing[0] || range[1] > enclosing[1])) {
                 report("lies outside the object that holds it", value);
             }
-            ASTNodeAccess parent = value instanceof ASTNodeAccessImpl
-                    ? ((ASTNodeAccessImpl) value).getParent()
-                    : null;
-            Node parentNode = parent == null ? null : parent.getASTNode();
-            if (parentNode != null && (parentNode.jjtGetFirstToken().absoluteBegin - 1 > range[0]
-                    || parentNode.jjtGetLastToken().absoluteEnd - 1 < range[1])) {
-                report("lies outside its parent " + parent.getClass().getSimpleName(), value);
-            }
+            checkInsideParent(value, range);
             ranges.add(new Object[] {range, value});
             String text = sql.substring(range[0], range[1]);
             // PRIOR is an operator only inside CONNECT BY
@@ -290,6 +287,17 @@ private void checkRange(Object value, int[] range, int[] enclosing) {
             }
         }
 
+        private void checkInsideParent(Object value, int[] range) {
+            ASTNodeAccess parent = value instanceof ASTNodeAccessImpl
+                    ? ((ASTNodeAccessImpl) value).getParent()
+                    : null;
+            Node parentNode = parent == null ? null : parent.getASTNode();
+            if (parentNode != null && (parentNode.jjtGetFirstToken().absoluteBegin - 1 > range[0]
+                    || parentNode.jjtGetLastToken().absoluteEnd - 1 < range[1])) {
+                report("lies outside its parent " + parent.getClass().getSimpleName(), value);
+            }
+        }
+
         private void checkReparses(Object value, String text, Parse parse) {
             Object again;
             try {
@@ -341,6 +349,7 @@ private static String normalized(String text) {
     }
 
     // a getter that builds new objects on each call computes them rather than holding them
+    @SuppressWarnings("PMD.CompareObjectsWithEquals")
     private static boolean isHeld(Object child, Object again) {
         if (child instanceof ASTNodeAccess) {
             return child == again;