cloud-harness/tools/deployment-cli-tools/tests/test_codefresh_internals.py at develop · MetaCell/cloud-harness · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
"""ch_cli_tools.codefresh generator tests, scoped to internal mechanics
that don't go through the public create_helm_chart/create_codefresh_deployment_scripts
facade - that end-to-end behavior belongs in test_codefresh.py instead.
See test_model.py (this folder) for the structural/model tests these build on.
"""

from conftest import minimal_project


def test_sort_parallel_steps_alphabetically(tmp_path):
    """Sub-steps inside parallel steps must be sorted alphabetically by name."""
    codefresh = minimal_project(tmp_path).codefresh

    steps = {
        "build_application_images_0": {
            "type": "parallel",
            "stage": "build",
            "steps": {
                "z-image": {"type": "build"},
                "a-image": {"type": "build"},
                "m-image": {"type": "build"},
                "b-image": {"type": "build"},
            },
        },
        "build_application_images_1": {
            "type": "parallel",
            "stage": "build",
            "steps": {
                "zz": {"type": "build"},
                "aa": {"type": "build"},
            },
        },
        "not_parallel": {
            "stage": "prepare",
            "title": "Not parallel",
        },
    }

    result = codefresh._sort_parallel_steps(steps)

    # Parallel sub-steps are sorted alphabetically.
    assert list(result["build_application_images_0"]["steps"].keys()) == [
        "a-image",
        "b-image",
        "m-image",
        "z-image",
    ]
    assert list(result["build_application_images_1"]["steps"].keys()) == ["aa", "zz"]
    # Non-parallel steps are unaffected.
    assert "not_parallel" in result


def test_order_steps_by_stage(tmp_path):
    """Steps must be sorted according to the stages list; relative order within each stage is preserved."""
    codefresh = minimal_project(tmp_path).codefresh
    stages = ["prepare", "build", "unittest", "deploy", "qa"]

    steps = {
        "build_step_1": {"stage": "build", "title": "Build 1"},
        "main_clone": {"stage": "prepare", "title": "Clone"},
        "prepare_deployment": {"stage": "prepare", "title": "Prepare"},
        "tests_unit": {"stage": "unittest", "title": "Unit tests"},
        "build_step_2": {"stage": "build", "title": "Build 2"},
        "deployment": {"stage": "deploy", "title": "Deploy"},
        "tests_e2e": {"stage": "qa", "title": "E2E tests"},
        "no_stage_step": {"title": "No stage"},
    }

    result = codefresh._order_steps_by_stage(steps, stages)
    step_names = list(result.keys())

    assert step_names.index("main_clone") < step_names.index("build_step_1"), (
        "prepare must precede build"
    )
    assert step_names.index("prepare_deployment") < step_names.index("build_step_1"), (
        "prepare must precede build"
    )
    assert step_names.index("build_step_1") < step_names.index("tests_unit"), (
        "build must precede unittest"
    )
    assert step_names.index("build_step_2") < step_names.index("tests_unit"), (
        "build must precede unittest"
    )
    assert step_names.index("tests_unit") < step_names.index("deployment"), (
        "unittest must precede deploy"
    )
    assert step_names.index("deployment") < step_names.index("tests_e2e"), (
        "deploy must precede qa"
    )

    # Relative order within each stage is preserved (stable sort).
    assert step_names.index("main_clone") < step_names.index("prepare_deployment"), (
        "relative order within prepare preserved"
    )
    assert step_names.index("build_step_1") < step_names.index("build_step_2"), (
        "relative order within build preserved"
    )

    # Steps without a stage come last.
    assert step_names.index("no_stage_step") == len(step_names) - 1, (
        "steps without a stage go to the end"
    )