Repository navigation
render-pinning: keep conda-build selectors in distro.yaml pinning_overrides - #199
Merged
Tobias-Fischer merged 1 commit intoNov 8, 2026
Merged
Conversation
6 tasks done
EzraBrooks
marked this pull request as draft
November 5, 2026 19:26
This comment was marked as resolved.
This comment was marked as resolved.
EzraBrooks
force-pushed
the
pinning-override-selectors
branch
from
November 5, 2026 19:36
1d995b7 to
55a9b45
Compare
EzraBrooks
marked this pull request as ready for review
November 5, 2026 19:37
switch override parsing to use a similar ruamel.yaml based approach to upstream conda-build so that overrides can contain selectors such as platform specs.
EzraBrooks
force-pushed
the
pinning-override-selectors
branch
from
November 5, 2026 20:12
55a9b45 to
ec0861f
Compare
Contributor
Author
|
sorry for the change after putting up for review, hopefully nobody was mid-read.. realized there was duplicate ruamel configs and consolidated them while in here |
Tobias-Fischer
approved these changes
Nov 5, 2026
traversaro
approved these changes
Nov 8, 2026
Member
|
@Tobias-Fischer it seems we can't override the failing CI, but I guess it would make sense to this in this case. |
Tobias-Fischer
added
the
build:none
Tobias-Fischer
enabled auto-merge (squash)
November 8, 2026 19:54
Collaborator
We can add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
switch override parsing to use a similar ruamel.yaml based approach to upstream conda-build so that overrides can contain selectors such as platform specs. adds a test to confirm retention of selectors.
This PR is the enabler for this part of #193 that encodes the minimum Python for Lyrical as 3.12 unless building for arm64 windows or riscv64 linux in which case it must be 3.14:
https://github.com/RoboStack/robostack/pull/193/changes#diff-78330d624099840ab8cfeb9f87a3fa51b25985822bd13aaa25afefab98c742a7R9-R23