Skip to content
This repository was archived by the owner on Oct 6, 2026. It is now read-only.

Replace print with logging - #679

Closed
outring wants to merge 2 commits into
Shopify:mainfrom
outring:fix/print-log
Closed

outring wants to merge 2 commits into
Shopify:mainfrom
outring:fix/print-log

Conversation

@outring

@outring outring commented Aug 18, 2023

Copy link
Copy Markdown

WHY are these changes introduced?

Fixes #678

Replacing raw print to stdout with logging to allow consuming applications decide how they want this data to be presented

WHAT is this pull request doing?

Replaced print with logging.Logger.exception. By default logging in Python prints all events with severity >= WARNING to the stdout/stderr so the existing behavior is maintained in general

Checklist

  • I have updated the CHANGELOG (if applicable)
  • I have followed the Shopify Python guide

@outring

outring commented Aug 18, 2023

Copy link
Copy Markdown
Author

Just signed the CLA but can't rerun the check myself, sorry. JFYI there are no mentions of CLA in any of the contribution guides around:

Probably worth adding there. I can do that in this PR if it's okay

@Suleimanlatrsh

Copy link
Copy Markdown
Contributor

Thanks for contributing! This package is deprecated and we're archiving this repo, so we're closing all open issues and PRs. Please use shopify-app-python instead, and open new issues there. More context: Rethinking support for PHP/Python packages

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-CLI parts of the library must not write anything to stdout/stderr

2 participants