refactor(@angular-devkit/core): simplify Set operations with ES2025 Set methods (#34505)

PR Close #34505

Author: alan-agius4

packages/angular_devkit/core/src/json/schema/utility.ts

@@ -53,7 +53,7 @@ export function getTypesOfSchema(schema: JsonSchema): Set<string> {
 
   if (isJsonObject(schema.not)) {
     const notTypes = getTypesOfSchema(schema.not);
-    potentials = new Set([...potentials].filter((p) => !notTypes.has(p)));
+    potentials = potentials.difference(notTypes);
   }
 
   if (Array.isArray(schema.allOf)) {
@@ -67,7 +67,7 @@ export function getTypesOfSchema(schema: JsonSchema): Set<string> {
     let options = new Set<string>();
     for (const sub of schema.oneOf) {
       const types = getTypesOfSchema(sub as JsonObject);
-      options = new Set([...options, ...types]);
+      options = options.union(types);
     }
     potentials = new Set([...options].filter((o) => potentials.has(o)));
   }
@@ -76,7 +76,7 @@ export function getTypesOfSchema(schema: JsonSchema): Set<string> {
     let options = new Set<string>();
     for (const sub of schema.anyOf) {
       const types = getTypesOfSchema(sub as JsonObject);
-      options = new Set([...options, ...types]);
+      options = options.union(types);
     }
     potentials = new Set([...options].filter((o) => potentials.has(o)));
   }

packages/angular_devkit/core/src/utils/partially-ordered-set.ts

@@ -84,34 +84,16 @@ export class PartiallyOrderedSet<T> {
       const itemDeps = this._items.get(item) || new Set<T>();
 
       // If the dependency list is equal, just return, otherwise remove and keep going.
-      let equal = true;
-      for (const dep of deps) {
-        if (!itemDeps.has(dep)) {
-          equal = false;
-          break;
-        }
-      }
-      if (equal) {
-        for (const dep of itemDeps) {
-          if (!deps.has(dep)) {
-            equal = false;
-            break;
-          }
-        }
-      }
-
-      if (equal) {
+      if (deps.size === itemDeps.size && deps.isSubsetOf(itemDeps)) {
         return this;
       } else {
         this._items.delete(item);
       }
     }
 
     // Verify all dependencies are part of the Set.
-    for (const dep of deps) {
-      if (!this._items.has(dep)) {
-        throw new DependencyNotFoundException();
-      }
+    if (!deps.isSubsetOf(this._items)) {
+      throw new DependencyNotFoundException();
     }
 
     // Verify there's no dependency cycle.