fixup! fix(@angular/build): capture and report Rolldown warnings and errors in library builder

Author: alan-agius4

packages/angular/build/src/builders/library/pipeline/build-action.ts

@@ -152,18 +152,14 @@ export async function buildAction(actionContext: BuildActionContext): Promise<vo
       throw error;
     }
 
-    for (const warning of [...warnings, ...bundleOutput.warnings]) {
-      context.logger.warn(warning);
-    }
-
-    if (bundleOutput.errors.length > 0) {
-      throw new Error(bundleOutput.errors.join('\n'));
-    }
-
     buildState.hasCompilationError = false;
     pendingChangedEsmFiles.clear();
     pendingChangedDtsFiles.clear();
 
+    for (const warning of [...warnings, ...bundleOutput.warnings]) {
+      context.logger.warn(warning);
+    }
+
     filesToEmit.push(...bundleOutput.filesToEmit);
     for (const [name, bundleResult] of bundleOutput.bundleResults) {
       buildState.previousBundleResults.set(name, bundleResult);

packages/angular/build/src/builders/library/pipeline/bundler.ts

@@ -37,9 +37,6 @@ export interface BundleEntryPointsOutput {
 
   /** Warning messages emitted during bundling. */
   warnings: string[];
-
-  /** Error messages emitted during bundling. */
-  errors: string[];
 }
 
 /**
@@ -74,9 +71,6 @@ interface MultiBundleOutput {
 
   /** Warning messages emitted during the bundle invocation. */
   warnings: string[];
-
-  /** Error messages emitted during the bundle invocation. */
-  errors: string[];
 }
 
 /**
@@ -97,7 +91,7 @@ export async function bundleEntryPoints(
 ): Promise<BundleEntryPointsOutput> {
   const bundleResults = new Map<string, BundleResult>();
   if (items.length === 0) {
-    return { filesToEmit: [], bundleResults, warnings: [], errors: [] };
+    return { filesToEmit: [], bundleResults, warnings: [] };
   }
 
   const esmEntryPoints: NormalizedEntryPoint[] = [];
@@ -135,7 +129,6 @@ export async function bundleEntryPoints(
     filesToEmit: [...esmOutput.filesToEmit, ...dtsOutput.filesToEmit],
     bundleResults,
     warnings: [...esmOutput.warnings, ...dtsOutput.warnings],
-    errors: [...esmOutput.errors, ...dtsOutput.errors],
   };
 }
 
@@ -324,27 +317,24 @@ async function executeMultiBundle(
   const isDts = extension === 'd.ts';
   const dir = isDts ? TYPES_OUTPUT_DIR : FESM_OUTPUT_DIR;
   const warnings: string[] = [];
-  const errors: string[] = [];
-  let bundle: Awaited<ReturnType<typeof rolldown>> | undefined;
+  const bundle = await rolldown({
+    context: 'this',
+    input,
+    plugins,
+    treeshake: false,
+    resolve: { symlinks: !preserveSymlinks },
+    checks: { circularDependency: false },
+    onLog(level, log) {
+      if (level === 'warn') {
+        warnings.push(log.message);
+      }
+    },
+    experimental: {
+      attachDebugInfo: 'none',
+    },
+  });
 
   try {
-    bundle = await rolldown({
-      context: 'this',
-      input,
-      plugins,
-      treeshake: false,
-      resolve: { symlinks: !preserveSymlinks },
-      checks: { circularDependency: false },
-      onLog(level, log) {
-        if (level === 'warn') {
-          warnings.push(log.message);
-        }
-      },
-      experimental: {
-        attachDebugInfo: 'none',
-      },
-    });
-
     const { output } = await bundle.generate({
       format: 'es',
       dir,
@@ -355,25 +345,12 @@ async function executeMultiBundle(
       comments: { jsdoc: isDts, legal: true, annotation: true },
     });
 
-    const { filesToEmit, moduleIdsByBundle } = processRolldownOutput(output, dir);
-
-    return {
-      filesToEmit,
-      moduleIdsByBundle,
-      warnings,
-      errors,
-    };
-  } catch (error) {
-    errors.push(error instanceof Error ? error.message : String(error));
-
     return {
-      filesToEmit: [],
-      moduleIdsByBundle: new Map(),
+      ...processRolldownOutput(output, dir),
       warnings,
-      errors,
     };
   } finally {
-    await bundle?.close();
+    await bundle.close();
   }
 }
 
@@ -391,7 +368,7 @@ async function bundleAllEsm(
   options: NormalizedLibraryOptions,
 ): Promise<MultiBundleOutput> {
   if (entryPoints.length === 0) {
-    return { filesToEmit: [], moduleIdsByBundle: new Map(), warnings: [], errors: [] };
+    return { filesToEmit: [], moduleIdsByBundle: new Map(), warnings: [] };
   }
 
   return executeMultiBundle(
@@ -417,7 +394,7 @@ async function bundleAllDts(
   options: NormalizedLibraryOptions,
 ): Promise<MultiBundleOutput> {
   if (entryPoints.length === 0) {
-    return { filesToEmit: [], moduleIdsByBundle: new Map(), warnings: [], errors: [] };
+    return { filesToEmit: [], moduleIdsByBundle: new Map(), warnings: [] };
   }
 
   const dtsSourcemap = options.declarationMap;