fix(@angular/cli): use unquoted specifier for registry manifest cache keys

The resolved-version manifest cache entry was stored using an unquoted `name@version` key while lookups on hosts that require shell quoting used a quoted key, so the entry was never reused. Both keys are now derived from the unquoted specifier.

Author: clydin

packages/angular/cli/src/package-managers/package-manager.ts

@@ -533,6 +533,18 @@ export class PackageManager {
     return metadata;
   }
 
+  /**
+   * Creates the in-memory cache key for a registry manifest.
+   *
+   * The key is intentionally based on the unquoted `name@version` specifier so that it is
+   * stable regardless of whether the host requires shell quoting for command arguments.
+   */
+  #getManifestCacheKey(packageName: string, version: string, registry?: string): string {
+    const specifier = `${packageName}@${version}`;
+
+    return registry ? `${specifier}|${registry}` : specifier;
+  }
+
   /**
    * Fetches the registry manifest for a specific version of a package.
    * The manifest is similar to the package's `package.json` file.
@@ -558,7 +570,7 @@ export class PackageManager {
       commandArgs.push(...formatter(MANIFEST_FIELDS));
     }
 
-    const cacheKey = options.registry ? `${specifier}|${options.registry}` : specifier;
+    const cacheKey = this.#getManifestCacheKey(packageName, version, options.registry);
     const normalizedRange = validRange(version);
 
     const manifest = await this.#fetchAndParse(
@@ -588,11 +600,10 @@ export class PackageManager {
 
     // If the provided version was not a specific version, also cache the specific fetched version
     if (manifest && manifest.version !== version) {
-      const manifestSpecifier = `${manifest.name}@${manifest.version}`;
-      const manifestCacheKey = options.registry
-        ? `${manifestSpecifier}|${options.registry}`
-        : manifestSpecifier;
-      this.#manifestCache.set(manifestCacheKey, manifest);
+      this.#manifestCache.set(
+        this.#getManifestCacheKey(manifest.name, manifest.version, options.registry),
+        manifest,
+      );
     }
 
     return manifest;

packages/angular/cli/src/package-managers/package-manager_spec.ts

@@ -180,6 +180,23 @@ describe('PackageManager', () => {
       );
     });
 
+    it('should reuse the resolved version cache entry when the host requires quoting', async () => {
+      Object.assign(host, { requiresQuoting: true });
+
+      const pm = new PackageManager(host, '/tmp', descriptor);
+      runCommandSpy.and.resolveTo({
+        stdout: JSON.stringify({ name: 'foo', version: '1.5.0' }),
+        stderr: '',
+      });
+
+      await pm.getRegistryManifest('foo', '^1.0.0');
+      expect(await pm.getRegistryManifest('foo', '1.5.0')).toEqual({
+        name: 'foo',
+        version: '1.5.0',
+      });
+      expect(runCommandSpy).toHaveBeenCalledTimes(1);
+    });
+
     it('should return null when bun pm view fails with No matching version found', async () => {
       const pm = new PackageManager(host, '/tmp', SUPPORTED_PACKAGE_MANAGERS['bun']);
       runCommandSpy.and.rejectWith(