You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b8ccb47
Browse filesBrowse the repository at this point in the historyBrowse files
fix: honor proxyUser/proxyPass when downloading the Local binary
proxyHost/proxyPort were threaded through to every binary-download
request (the async in-process path, and the two spawned child
scripts), but proxyUser/proxyPass were only ever forwarded to the
already-running BrowserStackLocal binary's own --proxy-user/--proxy-pass
flags - Local.js's conf object never carried them, so an authenticating
proxy accepted the binary's own traffic but rejected the download of
the binary itself.
Thread proxyUser/proxyPass through the same four call sites that
already handle proxyHost/proxyPort, building an HttpsProxyAgent `auth`
option ("user:pass", matching what https-proxy-agent expects for the
Proxy-Authorization header) from them. For the two spawned children
(download.js, fetchDownloadSourceUrl.js), pass the credentials via
env instead of argv, mirroring this codebase's existing
BROWSERSTACK_LOCAL_AUTH_TOKEN pattern - argv is readable via `ps`/
/proc/<pid>/cmdline, env is not.
Added 5 regression tests. Confirmed each fails against the pre-fix
code and passes with the fix.
Fixes#164
0 commit comments