Repository navigation
Conversation
…-7757) getBinConfig rebuilt testManagementOptions with testPlanId only, so issues, issueTracker and any other key set in the service options never reached the binary, which now sends the merged object as test_management_options at build start. Pass the object through as configured, still trimming testPlanId and dropping it when blank. Type issues and issueTracker and allow other keys. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
RUN_TESTS |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
[SDK Wdio Test] TRA build state: passed | Stability 100% — verdict: success. Passed: 52, Failed: 0, Aggregate: 52. TRA: https://observability.browserstack.com/builds/4a28rw4xf6kynccbb3buyuyoluxm3qbbuqwsjcai |
|
✅ Good to go
Change map (generated deterministically from the diff)graph LR
subgraph nwdio_service["wdio-service"]
npackages_browserstack_service_src_types_ts["types.ts<br/>~34 lines"]
npackages_browserstack_service_src_cli_cliUtils_ts["cliUtils.ts<br/>~18 lines"]
npackages_browserstack_service_tests_cli_cliUtils_test_ts["cliUtils.test.ts<br/>~18 lines"]
n_changeset_pr_285_md["pr-285.md<br/>~5 lines"]
end
↻ This verdict comment is the review anchor — it's updated in place on each run (the gate posts its status separately). — SDK PR Review Agent |
|
🟢 SDK PR Review gate is green — the SDK PR Review Agent has run on the current head commit (verdict: This gate confirms a review ran on the latest commit. The verdict itself is advisory — read the findings and use your judgement; it does not block merge. A native GitHub reviewer approval is still separately required by branch protection before this PR can merge. |
|
RUN_TESTS |
|
[SDK Wdio Test] TRA build state: failed | Stability 92% — verdict: failure. Passed: 49, Failed: 4, Aggregate: 53. TRA: https://observability.browserstack.com/builds/y5i7drvnjhqjft3xedystbge3etfmhoskk7rwhqa |
What is this about?
Customers can now pass any Test Management option to an automation run (first use: linking Jira issues to the Test Run, Q2 deal blocker) through one generic input, so new options need no SDK release:
browserstack.yml: the existingtestManagementOptions:blockBROWSERSTACK_TEST_MANAGEMENT_OPTIONS='{"issues":["XYZ-1","XYZ-2"],"issueTracker":{"name":"jira","host":"https://demo.atlassian.net"}}'--browserstack.testManagementOptions='<same json>'The binary merges them per top-level key (CLI > env > yml) and sends the result unchanged on build start as
test_management_options, next to the existingtest_management.test_plan_id. The legacyBROWSERSTACK_TEST_PLAN_ID/--browserstack.testManagementOptions.testPlanIdkeep working and still win fortestPlanId. Invalid or non-object JSON is ignored with a warning and never fails the build. Scope: frameworks whose build start goes through the binary.WDIO changes (v9) (binary flow = Mocha and Cucumber, not multiremote). Env and CLI need no change, because the service forwards raw argv and the binary inherits env.
CLIUtils.getBinConfigrebuilttestManagementOptionswith onlytestPlanId, soissues,issueTrackerand any other key in the service options never reached the binary. The newgetTestManagementOptionspasses the object through as configured. It still trimstestPlanIdand drops it when blank, and omits the key when nothing is left.TestManagementOptionsallows any key and documentsissues/issueTracker.BROWSERSTACK_TEST_PLAN_ID, so nothing to skip.Tested
testManagementOptionskeys to be dropped now expects them to be kept. Build andtscare clean.{"testPlanId":"12345"}.test_management_options/test_management.test_plan_id12345+ issues + issueTracker + customKey=--...testPlanId 12345/=TP-1BROWSERSTACK_TEST_PLAN_ID+ env JSON testPlanIdRelated Jira task/s
test_management_options; release it alongside this), Python #1302, Ruby #210, Java #2310, C# #1385, Node #2704, WDIO v9 #285, WDIO v8 #286Release (mandatory for every PR — required for the
ready-for-reviewlabel)Version bump: (required — tick exactly one)
Release notes type: (optional)
Release notes (customer-facing): (optional but encouraged)
testManagementOptionsset in the BrowserStack service options is now forwarded in full, soissuesandissueTrackercan link Jira issues to the build. The same JSON can be passed with theBROWSERSTACK_TEST_MANAGEMENT_OPTIONSenvironment variable or the--browserstack.testManagementOptionsCLI argument (Mocha and Cucumber).Release notes (internal): (required — engineer-facing; what actually changed / why)
Checklist
PR Validations
Run Tests: Comment RUN_TESTS to trigger sanity tests.
🤖 Generated with Claude Code