fix: npm 12 post-install scripts bug with npx (#70)

* fix: update to @lydell/node-pty which has no post install scripts

* feat: update to node-pty latest (1.2 beta) which has pre-compiled binaries and does not rely on post install scripts (node-gyp)

* fix: additional fixes for oclif (for npm 12) and remove windows in pretarball now. Bumped to official version 1.2.3

Author: kevinwang5658

README.md

@@ -1,6 +1,3 @@
-> ⚠️ **This package has been migrated and re-purposed.** The original package by [Andrew Stone](https://www.npmjs.com/~andrewjstone)
-> for transforming integers to base36 strings. To continue to use that functionality, please pin to version 0.3.0 or below.
-
 # Codify - Your Development Environment as Code
 
 **Stop manually setting up your development environment. Define it once, replicate it everywhere.**

package-lock.json

@@ -6,7 +6,7 @@
   "dependencies": {
     "@codifycli/ink-form": "0.0.12",
     "@codifycli/schemas": "1.2.0",
-    "@homebridge/node-pty-prebuilt-multiarch": "^0.13.1",
+    "@homebridge/node-pty-prebuilt-multiarch": "npm:node-pty@1.2.0-beta.15",
     "@mischnic/json-sourcemap": "^0.1.1",
     "@oclif/core": "^4.0.8",
     "@oclif/plugin-autocomplete": "^3.2.24",
@@ -36,6 +36,7 @@
     "kill-port": "^2.0.1",
     "latest-semver": "^4.0.0",
     "nanoid": "^5.0.9",
+    "node-pty": "1.2.0-beta.15",
     "open": "^10.1.2",
     "parse-json": "^8.1.0",
     "react": "^18.3.1",
@@ -133,7 +134,7 @@
     "build:release": "npm run pkg && ./scripts/notarize.sh",
     "lint": "tsc",
     "postpack": "shx rm -f oclif.manifest.json",
-    "pretarball": "../../../scripts/codesign.sh",
+    "pretarball": "../../../scripts/pretarball.sh",
     "pkg": "tsx ./scripts/pkg.ts",
     "notarize": "./scripts/notarize.sh",
     "upload": "./scripts/upload.sh",
@@ -149,7 +150,7 @@
     "prepublishOnly": "npm run build && npm run build:npm",
     "postpublish": "npm run restore-npm"
   },
-  "version": "1.2.2",
+  "version": "1.2.3",
   "bugs": "https://github.com/codifycli/codify/issues",
   "keywords": [
     "oclif",

package.json

@@ -2,5 +2,9 @@
 
 APPLE_DEVELOPER_APPLICATION_PROFILE=$(cat package.json | jq -r '.oclif.macos."application-certificate"')
 
-codesign --verbose=4 --timestamp --strict --options runtime -s "$APPLE_DEVELOPER_APPLICATION_PROFILE" node_modules/@homebridge/node-pty-prebuilt-multiarch/build/Release/spawn-helper --force
-codesign --verbose=4 --timestamp --strict --options runtime -s "$APPLE_DEVELOPER_APPLICATION_PROFILE" node_modules/@homebridge/node-pty-prebuilt-multiarch/build/Release/pty.node --force
+# node-pty ships its native binaries for every platform in prebuilds/<platform>-<arch>. Sign the copy installed under the
+# @homebridge alias too, since plugins built before the node-pty switch load that one.
+for dir in node_modules/node-pty/prebuilds/darwin-* node_modules/@homebridge/node-pty-prebuilt-multiarch/prebuilds/darwin-*; do
+  codesign --verbose=4 --timestamp --strict --options runtime -s "$APPLE_DEVELOPER_APPLICATION_PROFILE" "$dir/spawn-helper" --force
+  codesign --verbose=4 --timestamp --strict --options runtime -s "$APPLE_DEVELOPER_APPLICATION_PROFILE" "$dir/pty.node" --force
+done

scripts/codesign.sh

@@ -25,6 +25,9 @@
 // on fresh installs, causing the old cached version to be used. The patch must happen before
 // `oclif pack macos` runs — modifying the .pkg after the fact breaks notarization.
 //
+// Also patches node_modules/oclif/lib/tarballs/build.js to drop `--unsafe-perm` from its `npm pack` call. npm 12 removed
+// the flag (it has been a no-op since npm 7) and now fails with EUNKNOWNCONFIG. Still present as of oclif 6.0.15.
+//
 // If oclif upgrades and changes either file's structure, this script exits with code 1 so the
 // breakage is immediately visible.
 import { existsSync } from 'node:fs';
@@ -35,6 +38,7 @@ import { fileURLToPath } from 'node:url';
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
 const BIN_JS = path.join(__dirname, '../node_modules/oclif/lib/tarballs/bin.js');
 const MACOS_JS = path.join(__dirname, '../node_modules/oclif/lib/commands/pack/macos.js');
+const BUILD_JS = path.join(__dirname, '../node_modules/oclif/lib/tarballs/build.js');
 
 if (!existsSync(BIN_JS)) {
   console.log('oclif bin.js not found (likely production install). Skipping.');
@@ -130,3 +134,22 @@ if (!existsSync(MACOS_JS)) {
     console.log('Successfully patched oclif macos.js preinstall script');
   }
 }
+
+// Patch build.js to drop `--unsafe-perm` from `npm pack`. npm 12 rejects the unknown flag.
+const SEARCH_NPM_PACK = "exec('npm pack --unsafe-perm'";
+const PATCH_NPM_PACK = "exec('npm pack'";
+
+if (!existsSync(BUILD_JS)) {
+  console.log('oclif build.js not found. Skipping npm pack patch.');
+} else {
+  const buildContent = await fs.readFile(BUILD_JS, 'utf8');
+  if (buildContent.includes(SEARCH_NPM_PACK)) {
+    await fs.writeFile(BUILD_JS, buildContent.replace(SEARCH_NPM_PACK, PATCH_NPM_PACK), 'utf8');
+    console.log('Successfully patched oclif build.js npm pack command');
+  } else if (buildContent.includes(PATCH_NPM_PACK)) {
+    console.log('oclif build.js npm pack already patched. Skipping.');
+  } else {
+    console.error('ERROR: Could not find npm pack command in oclif build.js. The oclif version may have changed.');
+    process.exit(1);
+  }
+}

scripts/patch-oclif.ts

@@ -0,0 +1,10 @@
+#!/bin/bash
+# Runs via the `pretarball` npm script inside oclif's packing workspace (.build/tmp/codify), after oclif has installed
+# production dependencies there and before it builds each target. Changes to node_modules must happen here: oclif
+# re-installs dependencies into this workspace, so edits to .build/node_modules never reach the tarballs.
+set -e
+
+# node-pty bundles prebuilt binaries for every platform. The Windows ones are ~23MB per copy and no tarball targets Windows.
+rm -rf node_modules/node-pty/prebuilds/win32-* node_modules/@homebridge/node-pty-prebuilt-multiarch/prebuilds/win32-*
+
+"$(dirname "$0")/codesign.sh"

scripts/pretarball.sh

@@ -1,4 +1,4 @@
-import { IPty, spawn } from '@homebridge/node-pty-prebuilt-multiarch';
+import { IPty, spawn } from 'node-pty';
 import chalk from 'chalk';
 import { Router } from 'express';
 import WebSocket from 'ws';

src/connect/http-routes/create-command.ts

@@ -1,4 +1,4 @@
-import { spawn } from '@homebridge/node-pty-prebuilt-multiarch';
+import { spawn } from 'node-pty';
 import { ConfigFileSchema } from '@codifycli/schemas';
 import * as fs from 'node:fs/promises';
 import os from 'node:os';

src/connect/http-routes/handlers/apply-handler.ts

@@ -1,4 +1,4 @@
-import { spawn } from '@homebridge/node-pty-prebuilt-multiarch';
+import { spawn } from 'node-pty';
 import { ConfigFileSchema } from '@codifycli/schemas';
 import * as fs from 'node:fs/promises';
 import os from 'node:os';

src/connect/http-routes/handlers/destroy-handler.ts

@@ -1,4 +1,4 @@
-import { spawn } from '@homebridge/node-pty-prebuilt-multiarch';
+import { spawn } from 'node-pty';
 import { ConfigFileSchema } from '@codifycli/schemas';
 import { diffChars } from 'diff';
 import * as fs from 'node:fs/promises';