|
| 1 | +package com.retailsvc.http.internal; |
| 2 | + |
| 3 | +import static org.assertj.core.api.Assertions.assertThat; |
| 4 | +import static org.assertj.core.api.Assertions.assertThatThrownBy; |
| 5 | + |
| 6 | +import com.retailsvc.http.BadRequestException; |
| 7 | +import java.net.URI; |
| 8 | +import org.junit.jupiter.api.Test; |
| 9 | + |
| 10 | +class ExtrasPathValidatorTest { |
| 11 | + |
| 12 | + @Test |
| 13 | + void plainPathPasses() { |
| 14 | + URI uri = URI.create("/files/a/b.txt"); |
| 15 | + assertThat(ExtrasPathValidator.validateAndDecode(uri)).isEqualTo("/files/a/b.txt"); |
| 16 | + } |
| 17 | + |
| 18 | + @Test |
| 19 | + void dotDotSegmentRejected() { |
| 20 | + assertReject("/files/../etc/passwd"); |
| 21 | + } |
| 22 | + |
| 23 | + @Test |
| 24 | + void singleDotSegmentRejected() { |
| 25 | + assertReject("/files/./x"); |
| 26 | + } |
| 27 | + |
| 28 | + @Test |
| 29 | + void emptySegmentRejected() { |
| 30 | + assertReject("/files//x"); |
| 31 | + } |
| 32 | + |
| 33 | + @Test |
| 34 | + void encodedDotRejected() { |
| 35 | + assertReject("/files/%2e%2e/etc/passwd"); |
| 36 | + assertReject("/files/%2E/x"); |
| 37 | + } |
| 38 | + |
| 39 | + @Test |
| 40 | + void doubleEncodedDotRejected() { |
| 41 | + assertReject("/files/%252e%252e/etc/passwd"); |
| 42 | + } |
| 43 | + |
| 44 | + @Test |
| 45 | + void encodedSlashRejected() { |
| 46 | + assertReject("/files/%2fetc/passwd"); |
| 47 | + assertReject("/files/%2Fetc/passwd"); |
| 48 | + } |
| 49 | + |
| 50 | + @Test |
| 51 | + void backslashRejected() { |
| 52 | + assertReject("/files/x%5cy"); |
| 53 | + assertReject("/files/x%5Cy"); |
| 54 | + } |
| 55 | + |
| 56 | + @Test |
| 57 | + void literalBackslashRejected() throws Exception { |
| 58 | + URI uri = new URI("/files/x%5cy"); |
| 59 | + assertThatThrownBy(() -> ExtrasPathValidator.validateAndDecode(uri)) |
| 60 | + .isInstanceOf(BadRequestException.class); |
| 61 | + } |
| 62 | + |
| 63 | + @Test |
| 64 | + void nulByteRejected() { |
| 65 | + assertReject("/files/x%00.txt"); |
| 66 | + } |
| 67 | + |
| 68 | + @Test |
| 69 | + void controlCharRejected() { |
| 70 | + assertReject("/files/x%0ay"); |
| 71 | + } |
| 72 | + |
| 73 | + @Test |
| 74 | + void doubleEncodedPercentRejected() { |
| 75 | + assertReject("/files/%25xx"); |
| 76 | + assertReject("/files/%2500"); |
| 77 | + } |
| 78 | + |
| 79 | + private void assertReject(String raw) { |
| 80 | + URI uri = URI.create(raw); |
| 81 | + assertThatThrownBy(() -> ExtrasPathValidator.validateAndDecode(uri)) |
| 82 | + .isInstanceOf(BadRequestException.class); |
| 83 | + } |
| 84 | +} |
0 commit comments