Skip to content

Commit e5454cb

Browse files
feat: Drop Kernel's origin gate from 1Password fill
Stainless-Generated-From: 1f6da93b3427376e6526a1c28012a96279a47615
1 parent 56c9983 commit e5454cb

3 files changed

Lines changed: 9 additions & 7 deletions

File tree

‎src/kernel/resources/vaults/items.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1280,8 +1280,8 @@ def perform_operation(
12801280
page_url: Exact current top-level page URL. Must match exactly one open page in the
12811281
browser unless target_id is supplied.
12821282
1283-
entry_id: ID of an approved request entry. Required when several approved entries have the
1284-
page's origin.
1283+
entry_id: ID of an approved request entry. Required when several entries are approved and
1284+
the page's origin does not match exactly one of them.
12851285
12861286
target_id: CDP target ID of the page to fill, such as tab.target_id from
12871287
playwright.execute. Use it when several open pages have page_url. The page's
@@ -3285,8 +3285,8 @@ async def perform_operation(
32853285
page_url: Exact current top-level page URL. Must match exactly one open page in the
32863286
browser unless target_id is supplied.
32873287
3288-
entry_id: ID of an approved request entry. Required when several approved entries have the
3289-
page's origin.
3288+
entry_id: ID of an approved request entry. Required when several entries are approved and
3289+
the page's origin does not match exactly one of them.
32903290
32913291
target_id: CDP target ID of the page to fill, such as tab.target_id from
32923292
playwright.execute. Use it when several open pages have page_url. The page's

‎src/kernel/types/vaults/item_perform_operation_params.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,8 @@ class OnePasswordFillVaultItemOperationRequest(TypedDict, total=False):
235235
entry_id: str
236236
"""ID of an approved request entry.
237237
238-
Required when several approved entries have the page's origin.
238+
Required when several entries are approved and the page's origin does not match
239+
exactly one of them.
239240
"""
240241

241242
target_id: str

‎src/kernel/types/vaults/one_password_fill_vault_item_operation_request_param.py‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
class OnePasswordFillVaultItemOperationRequestParam(TypedDict, total=False):
1111
"""Fill and submit an approved 1Password login in the selected browser page.
1212
13-
The page must share the selected entry's login origin. Supply entry_id when more than one approved entry matches the page origin, and target_id when more than one open page has page_url. The extension selects fields; callers cannot supply selectors or secret values. Submission does not confirm website authentication.
13+
The 1Password extension decides whether the approved login matches the page and refuses pages that don't. Supply entry_id when several entries are approved and the page origin does not identify exactly one of them, and target_id when more than one open page has page_url. The extension selects fields; callers cannot supply selectors or secret values. Submission does not confirm website authentication.
1414
"""
1515

1616
browser_id: Required[str]
@@ -27,7 +27,8 @@ class OnePasswordFillVaultItemOperationRequestParam(TypedDict, total=False):
2727
entry_id: str
2828
"""ID of an approved request entry.
2929
30-
Required when several approved entries have the page's origin.
30+
Required when several entries are approved and the page's origin does not match
31+
exactly one of them.
3132
"""
3233

3334
target_id: str

0 commit comments

Comments
 (0)