Repository navigation
Conversation
| } | ||
| } | ||
|
|
||
| $sb = new StringBuffer(); |
There was a problem hiding this comment.
nit: I think the bug can still be reproduced without this block (up to line 124) wdyt ?
There was a problem hiding this comment.
Right, that block isn't needed. I've removed it and verified that the reduced test still fails without the fix and passes with it on a debug ZTS build.
558324d to
170bf2d
Compare
2bd8a6f to
170bf2d
Compare
|
The failing macOS CI job is due to an existing intl test compatibility issue exposed by the runner upgrading to ICU 79.1, unrelated to this JIT fix. The three failures are in the IntlDateFormatter::formatObject() calendar/DateTime tests and IntlTimeZone::getIDForWindowsID(): ICU 79.1 changed the Portuguese GMT offset formatting and the Canadian Pacific Standard Time mapping. These test expectation updates have been split into #24684. This PR now contains only the GH-24622 JIT fix and its regression test. The GH-24622 regression test passes locally on a debug ZTS build. Failing job: https://github.com/php/php-src/actions/runs/40182427911/job/121136134766 |
170bf2d to
a7fbaed
Compare
|
@devnexen could you take another look? Thanks |
5c57dd2 to
05fddfc
Compare
|
I just changed the username to my real name in news and force-pushed it as a single commit. |
|
@LamentXU123 as soon as you can, could you take a look at it? Thanks! |
Fixes #24622 by preserving spill requirements for register values inherited by side traces. Adds regression coverage; OPcache tests pass with debug ZTS and optimized NTS builds.