Repository navigation
Consume Enter key-ups that would trigger native focus advance in TextInput (#59247) - #59247
Closed
christophpurrer wants to merge 1 commit into
Closed
christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126482002. |
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 20, 2026
…Input (react#59247) Summary: - Problem: An Android TextInput crashes with `IllegalStateException: focus search returned a view that wasn't able to take focus!` from `ReactEditText.onKeyUp` when a numpad Enter, an editor-action Enter, or an Enter on a multiline email input is released. - Fix: Guard `ReactEditText.onKeyUp` so every Enter key-up that `TextView` would turn into native focus advance is consumed, so that focus moves only from JS and the input no longer crashes. Changelog: [Android][Fixed] - Fix TextInput crash when an Enter key-up triggers native focus search Differential Revision: D126482002
christophpurrer
force-pushed
the
export-D126482002
branch
from
October 20, 2026 22:51
591d660 to
c5164b9
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 20, 2026
…Input (react#59247) Summary: - Problem: An Android TextInput crashes with `IllegalStateException: focus search returned a view that wasn't able to take focus!` from `ReactEditText.onKeyUp` when a numpad Enter, an editor-action Enter, or an Enter on a multiline email input is released. - Fix: Guard `ReactEditText.onKeyUp` so every Enter key-up that `TextView` would turn into native focus advance is consumed, so that focus moves only from JS and the input no longer crashes. Changelog: [Android][Fixed] - Fix TextInput crash when an Enter key-up triggers native focus search Differential Revision: D126482002
christophpurrer
force-pushed
the
export-D126482002
branch
from
October 20, 2026 22:51
c5164b9 to
517e0d1
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 20, 2026
…Input (react#59247) Summary: Pull Request resolved: react#59247 - Problem: An Android TextInput crashes with `IllegalStateException: focus search returned a view that wasn't able to take focus!` from `ReactEditText.onKeyUp` when a numpad Enter, an editor-action Enter, or an Enter on a multiline email input is released. - Fix: Guard `ReactEditText.onKeyUp` so every Enter key-up that `TextView` would turn into native focus advance is consumed, so that focus moves only from JS and the input no longer crashes. Changelog: [Android][Fixed] - Fix TextInput crash when an Enter key-up triggers native focus search Differential Revision: D126482002
christophpurrer
force-pushed
the
export-D126482002
branch
from
October 20, 2026 22:54
517e0d1 to
45c7c0e
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 20, 2026
…Input (react#59247) Summary: Pull Request resolved: react#59247 - Problem: An Android TextInput crashes with `IllegalStateException: focus search returned a view that wasn't able to take focus!` from `ReactEditText.onKeyUp` when a numpad Enter, an editor-action Enter, or an Enter on a multiline email input is released. - Fix: Guard `ReactEditText.onKeyUp` so every Enter key-up that `TextView` would turn into native focus advance is consumed, so that focus moves only from JS and the input no longer crashes. Changelog: [Android][Fixed] - Fix TextInput crash when an Enter key-up triggers native focus search Differential Revision: D126482002
christophpurrer
force-pushed
the
export-D126482002
branch
from
October 20, 2026 23:01
45c7c0e to
dda7783
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 20, 2026
…Input (react#59247) Summary: - Problem: An Android TextInput crashes with `IllegalStateException: focus search returned a view that wasn't able to take focus!` from `ReactEditText.onKeyUp` when a numpad Enter, an editor-action Enter, or an Enter on a multiline email input is released. - Fix: Guard `ReactEditText.onKeyUp` so every Enter key-up that `TextView` would turn into native focus advance is consumed, so that focus moves only from JS and the input no longer crashes. Changelog: [Android][Fixed] - Fix TextInput crash when an Enter key-up triggers native focus search Differential Revision: D126482002
christophpurrer
force-pushed
the
export-D126482002
branch
from
October 20, 2026 23:34
dda7783 to
c903d8a
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 20, 2026
…Input (react#59247) Summary: Pull Request resolved: react#59247 - Problem: An Android TextInput crashes with `IllegalStateException: focus search returned a view that wasn't able to take focus!` from `ReactEditText.onKeyUp` when a numpad Enter, an editor-action Enter, or an Enter on a multiline email input is released. - Fix: Guard `ReactEditText.onKeyUp` so every Enter key-up that `TextView` would turn into native focus advance is consumed, so that focus moves only from JS and the input no longer crashes. Changelog: [Android][Fixed] - Fix TextInput crash when an Enter key-up triggers native focus search Differential Revision: D126482002
christophpurrer
force-pushed
the
export-D126482002
branch
from
October 20, 2026 23:37
c903d8a to
35d0f8f
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 21, 2026
…Input (react#59247) Summary: - Problem: An Android TextInput crashes with `IllegalStateException: focus search returned a view that wasn't able to take focus!` from `ReactEditText.onKeyUp` when a numpad Enter, an editor-action Enter, or an Enter on a multiline email input is released. - Fix: Guard `ReactEditText.onKeyUp` so every Enter key-up that `TextView` would turn into native focus advance is consumed, so that focus moves only from JS and the input no longer crashes. Changelog: [Android][Fixed] - Fix TextInput crash when an Enter key-up triggers native focus search Differential Revision: D126482002
christophpurrer
force-pushed
the
export-D126482002
branch
2 times, most recently
from
October 22, 2026 15:39
66761f6 to
0acee1d
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 22, 2026
…Input (react#59247) Summary: - Problem: An Android TextInput crashes with `IllegalStateException: focus search returned a view that wasn't able to take focus!` from `ReactEditText.onKeyUp` when a numpad Enter, an editor-action Enter, or an Enter on a multiline email input is released. - Fix: Guard `ReactEditText.onKeyUp` so every Enter key-up that `TextView` would turn into native focus advance is consumed, so that focus moves only from JS and the input no longer crashes. Changelog: [Android][Fixed] - Fix TextInput crash when an Enter key-up triggers native focus search Differential Revision: D126482002
…Input (react#59247) Summary: Pull Request resolved: react#59247 - Problem: An Android TextInput crashes with `IllegalStateException: focus search returned a view that wasn't able to take focus!` from `ReactEditText.onKeyUp` when a numpad Enter, an editor-action Enter, or an Enter on a multiline email input is released. - Fix: Guard `ReactEditText.onKeyUp` so every Enter key-up that `TextView` would turn into native focus advance is consumed, so that focus moves only from JS and the input no longer crashes. Changelog: [Android][Fixed] - Fix TextInput crash when an Enter key-up triggers native focus search Differential Revision: D126482002
christophpurrer
force-pushed
the
export-D126482002
branch
from
October 22, 2026 15:42
0acee1d to
835ce9c
Compare
Collaborator
|
This pull request was successfully merged by @christophpurrer in 04ccd83 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 04ccd83. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
IllegalStateException: focus search returned a view that wasn't able to take focus!fromReactEditText.onKeyUpwhen a numpad Enter, an editor-action Enter, or an Enter on a multiline email input is released.
ReactEditText.onKeyUpso every Enter key-up thatTextViewwould turn into native focus advance isconsumed, so that focus moves only from JS and the input no longer crashes.
Changelog:
[Android][Fixed] - Fix TextInput crash when an Enter key-up triggers native focus search
Differential Revision: D126482002