Skip to content

Delete deprecated RCTProfile systrace feature (#59323) - #59323

Closed
christophpurrer wants to merge 1 commit into
react:mainfrom
christophpurrer:export-D126581734
Closed

christophpurrer wants to merge 1 commit into
react:mainfrom
christophpurrer:export-D126581734

Conversation

@christophpurrer

@christophpurrer christophpurrer commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

RCTProfile hooked bridge modules for systrace capture, driven only by the deleted legacy bridge. With all call sites migrated or removed, delete the header, implementation, trampolines, and remaining hooks in the display link, module methods, performance logger, and downstream systrace callers.

Changelog:
[iOS][Removed] - Remove deprecated RCTProfile systrace API

Reviewed By: shwanton

Differential Revision: D126581734

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2026
@meta-codesync

meta-codesync Bot commented Oct 21, 2026

Copy link
Copy Markdown

@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126581734.

@meta-codesync meta-codesync Bot changed the title Delete deprecated RCTProfile systrace feature Delete deprecated RCTProfile systrace feature (#59323) Oct 22, 2026
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 22, 2026
Summary:
Pull Request resolved: react#59323

RCTProfile hooked bridge modules for systrace capture, driven only by the deleted legacy bridge. With all call sites migrated or removed, delete the header, implementation, trampolines, and remaining hooks in the display link, module methods, performance logger, and downstream systrace callers.

Changelog:
[iOS][Removed] - Remove deprecated RCTProfile systrace API

Reviewed By: shwanton

Differential Revision: D126581734
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Visual regression

1 visual difference(s) at 849b3f6212f7. Visual differences need maintainer approval. Review the report, then apply visual-change-approved.

android: no capture

ios button/two-buttons-flexbox/default: Changed, 280048 px (11.234%)

diff

Expected and Captured
Expected Captured
expected captured

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 22, 2026
Summary:
Pull Request resolved: react#59323

RCTProfile hooked bridge modules for systrace capture, driven only by the deleted legacy bridge. With all call sites migrated or removed, delete the header, implementation, trampolines, and remaining hooks in the display link, module methods, performance logger, and downstream systrace callers.

Changelog:
[iOS][Removed] - Remove deprecated RCTProfile systrace API

Reviewed By: shwanton

Differential Revision: D126581734
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 23, 2026
Summary:

RCTProfile hooked bridge modules for systrace capture, driven only by the deleted legacy bridge. With all call sites migrated or removed, delete the header, implementation, trampolines, and remaining hooks in the display link, module methods, performance logger, and downstream systrace callers.

Changelog:
[iOS][Removed] - Remove deprecated RCTProfile systrace API

Reviewed By: shwanton

Differential Revision: D126581734
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 23, 2026
Summary:

RCTProfile hooked bridge modules for systrace capture, driven only by the deleted legacy bridge. With all call sites migrated or removed, delete the header, implementation, trampolines, and remaining hooks in the display link, module methods, performance logger, and downstream systrace callers.

Changelog:
[iOS][Removed] - Remove deprecated RCTProfile systrace API

Reviewed By: shwanton

Differential Revision: D126581734
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 23, 2026
Summary:

RCTProfile hooked bridge modules for systrace capture, driven only by the deleted legacy bridge. With all call sites migrated or removed, delete the header, implementation, trampolines, and remaining hooks in the display link, module methods, performance logger, and downstream systrace callers.

Changelog:
[iOS][Removed] - Remove deprecated RCTProfile systrace API

Reviewed By: shwanton

Differential Revision: D126581734
Summary:

RCTProfile hooked bridge modules for systrace capture, driven only by the deleted legacy bridge. With all call sites migrated or removed, delete the header, implementation, trampolines, and remaining hooks in the display link, module methods, performance logger, and downstream systrace callers.

Changelog:
[iOS][Removed] - Remove deprecated RCTProfile systrace API

Reviewed By: shwanton

Differential Revision: D126581734
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @christophpurrer in d3c2bb8

When will my fix make it into a release? | How to file a pick request?

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 23, 2026
@meta-codesync

meta-codesync Bot commented Oct 23, 2026

Copy link
Copy Markdown

This pull request has been merged in d3c2bb8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants