Repository navigation
Conversation
Summary: On iOS, when \headers\ are provided in an \ImageSource\ prop (either as an object or as the first element of an array source), they were not extracted or passed to \ ativeProps.headers\. As a result, custom request headers defined on image sources (such as \Authorization\) were not forwarded to native on iOS, unlike Android which handles this in Image.android.js. This updates \Image.ios.js\ to extract \headers\ from \ esolvedSource\ and attach them to \ ativeProps.headers\ if present, aligning iOS with \Image.android.js\. ## Changelog: [IOS] [FIXED] - Forward headers from ImageSource in Image component Test Plan: - Verified Flow check passes cleanly (\yarn flow\) - Verified ESLint and Prettier pass on modified file - Verified existing Image tests pass (\yarn test packages/react-native/Libraries/Image\)
|
Hi @lewando54! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
Summary
On iOS, when
headersare provided in anImageSourceprop (either as an object or as the first element of an array source), they were not extracted or passed tonativeProps.headers. As a result, custom request headers defined on image sources (such asAuthorization) were not forwarded to native on iOS, unlike Android which handles this inImage.android.js(see #56905).This updates
Image.ios.jsto extractheadersfromresolvedSourceand attach them tonativeProps.headersif present, aligning iOS withImage.android.js.Changelog:
[IOS] [FIXED] - Forward headers from ImageSource in Image component
Test Plan:
yarn flow(0 errors)yarn test packages/react-native/Libraries/Image