Repository navigation
Conversation
added 5 commits
October 21, 2026 12:35
Update Go toolchain and runtime requirement to 1.26.10 addressing intermediate CA validation compromise (go.dev/issue/82345).
# Conflicts: # go.mod # go.sum
Stackitcre 382 registry fixes
GokceGK
reviewed
Nov 2, 2026
| isValid: false, | ||
| }, | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
You can add here more test cases like empty or invalid artifactoryId, no flagValues no argValues etc. You can see the delete tests from other services as example.
GokceGK
reviewed
Nov 2, 2026
| isValid: false, | ||
| }, | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
As I mentioned in the delete_test, here you can also extend the tests with more test cases.
GokceGK
reviewed
Nov 2, 2026
| isValid: false, | ||
| }, | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
as mentioned in the tests of delete and describe commands, here we can also add more test cases. At least invalid artifactory id checks
GokceGK
reviewed
Nov 2, 2026
| model.KMSCustomEndpoint = false | ||
| }), | ||
| }, | ||
| { |
Contributor
There was a problem hiding this comment.
please add a test in here for the empty endpoint case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://jira.schwarz/browse/STACKITCRE-382
Relates to STACKITCRE-382
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)