Repository navigation
Decline a tanh-substitution answer that says nothing where the integrand is defined - #1983
Merged
Rafael-SOWNet merged 1 commit intoOct 21, 2026
Conversation
…and is defined u answer on the real domain of the question in u, and tanh(L) takes only the values in (-1, 1). sqrt(1 - coth(x)^2), which is i |csch(x)|, is real in u only for |u| > 1, and came back as two arms for u <= -1 and u >= 1: true nowhere on the real line, so the answer had no value at any real x. Written back in x, an answer with no value at any sampled point where the integrand has one is now declined, and the rules in x answer as they did before #1956. Rubi's 6.4.7:31, 33 and 37 go from PART to OK with their answers from before fractional powers of tanh or coth, these three alone move; #1956's 36 gained rows answer as on master. Part of #233. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
Rafael-SOWNet
force-pushed
the
decline-a-tanh-answer-that-says-nothing-where-the-integrand-is-defined
branch
from
October 21, 2026 00:07
2093e93 to
161753b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1956 asks a function of the hyperbolic tangent in
u = tanh(L). The rules inuanswer on the real domain of the question inu, andtanh(L)takes only the values in(-1, 1).sqrt(1 - coth(x)^2), which isi |csch(x)|, is real inuonly for|u| > 1. Its answer came back as two arms, foru <= -1andu >= 1, and neither holds anywhere on the real line, so the answer had no value at any realx.Written back in x, an answer that has no value at any sampled point where the integrand has one is now declined, and the rules in x answer as they did before #1956. The check is
PartialFractions.SaysNothingWhereTheIntegrandIsDefined. It usesHoldsAtSampledPoints's pins and points, takes a value it cannot tell as a value, and stops at the first point where the answer has one. It evaluates under the settings the answer is returned in, because with the downcasting off a shared subtree kept a1/1that the answer then printed.Measured on
8270086f, branch against master:Re-run alone, Rubi's 6.4.7:31, 33 and 37 (
sqrt(1-coth(x)^2),(1-coth(x)^2)^(3/2)and1/sqrt(1-coth(x)^2)) go from an answer with no value to verified answers, in 0.5 s. Those answers are identical, character for character, to the ones before #1956. The other three moves, 3.2.1:292, 6.6.1:25 and 7.4.1:369, are answered on both builds in 16–24 s, against a 5 s budget.Of 253 rows of 6.3.x and 6.4.x with roots or fractional powers of tanh or coth, only these three move, and #1956's 36 gained rows answer as on master. v2.5.0 declined all three, so
BREAKING-CHANGES.mdhas no entry. No run had a wrong answer except 6.1.5:94 on both builds, the evaluator artefact of #1944.This touches the same rule as #1982; whichever merges second takes one rebase.
AFunctionOfTheHyperbolicTangentIntegralTestanswers the three and differentiates them back at six points, negative x included, comparing complex values.Part of #233.
🤖 Generated with Claude Code
https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura