Repository navigation
The Linux and macOS test legs run the suite without instrumenting it - #2168
Merged
Rafael-SOWNet merged 1 commit intoOct 27, 2026
Merged
Conversation
Both legs passed /p:CollectCoverage=true to dotnet test. Coverlet's MSBuild integration then instrumented the kernel and printed `AngouriMath | 0%` on every run, because VSTest stops the test host before coverlet writes its hits (the first entry of coverlet's KnownIssues.md). Nothing uploads either report: the Windows leg's collector report is the one sent to Codecov. The instrumentation was not free. On master 90ac975 the test step took 16 m 47 s on Linux and 29 m 2 s on macOS. Locally the full suite takes 12 m 9 s instrumented and 7 m 7 s to 7 m 52 s without, so about two fifths of it went on a report of nothing. Coverage.md's table says where the C# coverage comes from. Part of #397 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2168 +/- ##
==========================================
- Coverage 86.41% 86.41% -0.01%
==========================================
Files 295 295
Lines 64806 64806
Branches 19059 19059
==========================================
- Hits 56005 56004 -1
- Misses 4771 4772 +1
Partials 4030 4030
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Rafael-SOWNet
deleted the
the-linux-and-macos-legs-test-without-coverage
branch
October 28, 2026 10:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux and macOS, C# Test passed
/p:CollectCoverage=truetodotnet test. Coverlet's MSBuild integration instrumented the kernel and printedAngouriMath | 0%on every run. The cause is the first entry of coverlet's KnownIssues.md: VSTest stops the test host before coverlet writes its hits. Nothing uploads either report. The Windows leg's collector report is the one Codecov gets (#2165).What the instrumentation cost:
90ac9752a, the test step took 16 m 47 s on Linux and 29 m 2 s on macOS.This PR drops the two properties, and
Coverage.md's table now says the C# coverage comes from the Windows leg. Measured on this PR (dotnet test's own duration line, one run each):90ac9752aBoth legs ran all 17,141 tests, and neither printed the 0% table.
Part of #397.
🤖 Generated with Claude Code
https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura