Repository navigation
The docs' pages with a '#' in their names are served and linked - #56
Merged
Merged
Conversation
The compiler names a constructor #ctor and writes the dots in the name of an explicitly implemented interface member as '#', and Yadg.NET names a member's page after it: Erff/#ctor.html, Setting`1/AngouriMath#Convenience#ISettingState#CurrentState.html. Two things broke 117 links to them. GitHub Pages runs the gh-pages branch through Jekyll, which leaves out every file whose name starts with '#', so not one of the 115 constructors' pages on the site was published. The generator now writes a .nojekyll. No page here has front matter and nothing is in Sass or markdown, so Jekyll only ever copied the files, apart from the ones it dropped. And Yadg.NET wrote the '#' into each link as it was, where it begins the fragment, so the browser asked for Erff/ and for Setting`1/AngouriMath. Links to a member's page and cross-references now write it as %23; the sitemap already did. A link check of a local build goes from 244 broken links to 121, and none of the 121 is either of these. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler names a constructor
#ctor, and writes the dots in the name of an explicitly implemented interface member as#. Yadg.NET names a member's page after it:Erff/#ctor.html,Setting`1/AngouriMath#Convenience#ISettingState#CurrentState.html. 117 links to these pages were broken, for two reasons:gh-pagesthrough Jekyll, which leaves out every file whose name starts with#. None of the site's 115 constructor pages was ever published:https://am.angouri.org/docs/AngouriMath.Entity/Erff/%23ctor.htmlis a 404, and the same file onraw.githubusercontent.comis a 200. The generator now writes a.nojekyll.wiki/_Footer.html.#as it was, where it begins the fragment. So the browser asked forErff/and forSetting`1/AngouriMath. Links to a member's page and cross-references now write it as%23, inYadg.NET.patch. The sitemap already escapes it.Checked on a local build: 238 broken links before, 121 after, and none of the 121 is either of these. The local build has 116 constructor pages, because it is built from the library's current master.
The 121 that are left:
Interval.Left, and nested types such asSize.Aleph. Next PRFigures corrected after merging. The first version counted a local build whose
.output/prestill held pages from older builds:amsite.fsx cleanremoves only.output/final, and every page inpreis copied intofinal. The figures above come from builds with no earlier output, at each stage of the patch. The deployed site has the same 5,028 pages.🤖 Generated with Claude Code
https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura