Repository navigation
fix(ci): test parser parity and diagrams by behaviour, not version pins - #151
Merged
Merged
Conversation
Dependabot PRs failed CI for reasons unrelated to whether the knowledge base works: - artifact-checks.spec.js asserted that the root package.json pins htmlparser2, postcss and mermaid at exactly the versions actions/ pins. Dependabot only watched /, so every parser bump was red by construction and actions/ was never bumped. The spec now runs the checker self-test against whichever parsers the build resolves: a root parser that parses differently still fails, one that does not can land on its own. mermaid leaves the Dependabot ignore list (the rendering tests hold the fixture bundle to working), and Dependabot now also watches /actions. - The Mermaid suite failed on any console error. Chromium in Playwright 1.65 reports reframed's iframe `unload` listener as a permissions-policy violation; the diagram still renders. That one message is ignored; uncaught page errors and every other console error still fail. - check.selftest.js normalises CRLF before parsing RULES.md, so it also passes on a Windows checkout now that the root suite runs it. Fixes #150 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
oto-macenauer-absa
added a commit
that referenced
this pull request
Nov 11, 2026
Replaces #110. Dependabot could no longer rebase or recreate it (it carried a manual merge from master), so this re-applies the same bump on current master. Relates to #150: since #151 the root and \`actions/\` may resolve different parser versions. The checker self-test in \`tests/artifact-checks.spec.js\` runs against this root htmlparser2 12 and passes locally, along with \`private-registry\` and \`transform\` (46/46). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #150. Dependabot PRs were red for reasons unrelated to whether the knowledge base works. This replaces the version-pinning assertions with behavioural ones and stops the Mermaid suite from failing on browser deprecation noise.
tests/artifact-checks.spec.jsno longer requires the roothtmlparser2/postcss/mermaidversions to matchactions/package.json. Instead it runsactions/lib/check.selftest.js(which pins every rule's findings) against whichever parsers the build resolves. In CI's E2E job that means the root tree, and the actions job still covers theactions/tree. A root parser that parses differently fails; one that doesn't can land on its own.mermaidleaves the rootignorelist, because the Mermaid E2E tests hold the fixture bundle to rendering. A new/actionsnpm entry (minor/patch grouped) means the dependencies we ship to docs repos are bumped too.iframeWindow.addEventListener("unload", …)(web-fragments 0.8.2) asPermissions policy violation: unload is not allowed in this document.That exact message is now ignored. Uncaught page errors and every other console error still fail.check.selftest.jsnormalises CRLF before parsingcontract/RULES.md. A Windows checkout failed the catalogue check, and it matters now that the root suite runs the self-test.scripts/check-artifact.jsandscripts/setup-test-apps.mjs, andCLAUDE.md, no longer claim the two package files are pinned in step.Verification
npm test, Playwright 1.62.1 (current pin): 460 passed, 0 failed.postcss@8.5.32+htmlparser2@12.0.0swapped intonode_modules(what chore(deps): bump postcss from 8.5.28 to 8.5.32 #137 and chore(deps): bump htmlparser2 from 8.0.2 to 12.0.0 #110 do): the checker self-test passes.@playwright/test@1.65.0(what chore(deps-dev): bump the dev-dependencies group across 1 directory with 10 updates #149 brings): 6 failures without this change (same as chore(deps-dev): bump the dev-dependencies group across 1 directory with 10 updates #149's CI), 8/8 pass with it.After merge
Rebasing #137, #110 and #149 should turn them green (#149 also needs #148 merged for its PR Requirements check).
🤖 Generated with Claude Code