Repository navigation
Fix set_val_at #175 - #176
Merged
luketpeterson merged 2 commits intoNov 3, 2026
Merged
luketpeterson merged 2 commits into
luketpeterson merged 2 commits into
Conversation
When the write zipper's focus has no child node of its own, `with_node_at_path` joined the focus key and the relative path and handed the whole key to the parent node's `node_set_val` / `node_set_branch`. Those expect a key that doesn't pass through a child, so a child further along the key (e.g. `xa` from earlier writes of `xab` and `xac`) was split around instead of entered. The write then landed beside the existing path, giving a duplicate value or a value the trie can't reach (Adam-Vandervorst#175). It now enters such a child, as the root case already does. The branch for a focus key plus path longer than a node key had the same defect inside the subtrie it takes from below the focus, and now walks it the same way. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Good fix for a nasty bug. Could also have impacted zipper creation at a relative path too. |
Adding set_val_at to lean model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude 5.5 xhigh:
When the write zipper's focus has no child node of its own,
with_node_at_pathjoined the focus key and the relative path and handed the whole key to the parent node'snode_set_val/node_set_branch. Those expect a key that doesn't pass through a child, so a child further along the key (e.g.xafrom earlier writes ofxabandxac) was split around instead of entered. The write then landed beside the existing path, giving a duplicate value or a value the trie can't reach (#175). It now enters such a child, as the root case already does.The branch for a focus key plus path longer than a node key had the same defect inside the subtrie it takes from below the focus, and now walks it the same way.