Repository navigation
Make take_map and restricting ignore empty materialised nodes - #183
Merged
imlvts merged 1 commit intoNov 4, 2026
Merged
Conversation
At a focus with nothing below it, these answered according to whether an
empty node happened to exist there (after create_path or remove_val, say)
rather than according to the trie's paths and values:
- take_map returned Some(empty map) instead of None, and for a focus
holding only a value it returned a map whose root node was that empty
node, which panicked on the first write below the root ("make_unique on
an empty sentinel node");
- restricting with a dangling source focus erased the destination's
branches and returned true; either side with nothing below its focus
now leaves the destination alone and returns false, as it already did
for a source focus that does not exist.
Owner
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At a focus with nothing below it, these answered according to whether an empty node happened to exist there (after create_path or remove_val, say) rather than according to the trie's paths and values: