Repository navigation
Re-descend the node stack after prune_path restructures the focus's node - #184
Merged
Merged
Conversation
Removing a dangling path can restructure the node above the focus so that the focus key now runs through a child node the stack has not descended into. prune_path left the stack there, so later writes at the focus went into the wrong node: - a write could put its key into the parent beside that child: a LineListNode with keys "\0" and "\0\0\0", which the node validator rejects as an ambiguous path (found by crash_fuzz); - graft_masked_branches below a zipper root that survives as a dangling path merged the branches into the node above the focus, two bytes too shallow (a debug build trips the consumed-bytes assertion). Descend again after pruning.
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing a dangling path can restructure the node above the focus so that the focus key now runs through a child node the stack has not descended into. prune_path left the stack there, so later writes at the focus went into the wrong node: