Repository navigation
Conversation
Member
|
Hey, thanks for the PR. Could you sign the CLA when you get a chance so we can review it? |
Author
Happy to sign! Could you share the CLA signing link? The license/cla check currently shows "Expected" without a link. |
Author
|
Thanks! I've now signed the CLA as 0xMrMasry, and CLA Assistant showed the confirmation: "Thank you 0xMrMasry for signing the CLA!" The PR still appears to be waiting for |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
On native Windows, a fresh
codeaflaunch disables memory, conversation search, and automations withSQL logic error: out of memory (1). The database openers passnet/url.URLa Windows drive path, producingfile://C:%5C.... SQLite rejects that URI before opening a database. With the same driver and machine,:memory:, a plain filename, andfile:///C:/...all open successfully.Add a shared file-URI constructor that uses forward slashes and a rooted URL path, then use it in the graph, automation, collection, and read-only plan-preview database openers. POSIX absolute paths keep their existing URI shape, and query parameters remain with each caller. The regression test exercises persistence at the requested filename with spaces,
#,&, and%, connection pragmas, and read-only access.Related to #1082. This addresses database opening; the separate Windows resume/presence-locking problems remain outside this change.
How it was checked
On Windows amd64 with Go 1.26.5 and the repository's modernc.org/sqlite v1.29.1:
go test ./internal/automation -run '^TestStoreRefusesAForeignDatabase$' -count=1fails with the reported SQLite error.git diff --checkpasses.go vet ./internal/sqliteuri ./internal/store ./internal/automation ./internal/workspace ./internal/plandbpasses.make changelog-checkpasses, including the entry for fix: correct SQLite file URIs on Windows #1868.make pr-readypassesgo build ./...and then fails atgo vet ./...because unmodified tests use Unix-onlysyscall.Setpgid,syscall.Kill, andsyscall.Flock, and other unmodified test helpers/packages are excluded on Windows. The full local gate therefore does not pass.Checklist
.github/known-red.txt.