Skip to content

feat: dbt_sql_graph tool — a model's CTEs, joins and filters as a graph - #1735

Open
hkaltai wants to merge 10 commits into
mainfrom
feat/dbt-sql-graph-tool
Open

hkaltai wants to merge 10 commits into
mainfrom
feat/dbt-sql-graph-tool

Conversation

@hkaltai

@hkaltai hkaltai commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Issue for this PR

None

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Adds the dbt_sql_graph { model } tool. It compiles the model with the project's dbt integration, reads its non-ephemeral parents' columns from the warehouse's metadata, and sends the compiled SQL to the Altimate backend's dbt/v3/sql_lineage endpoint (api/sql-lineage.ts). The backend's __final_select__ is renamed after the model and each relation node is tied to its dbt unique id by name, database and schema (a relation two parents could both be is tied to neither). The result is { nodes: [{ id, name, type, nodeId?, sql, columns }], edges: [[fromId, toId]] } (id is the backend's unique node key; name is only what is shown and can repeat; a join or filter's expression is its sql) plus a one-line-per-node text list. It is adapter-backed, so it needs write permission and an Altimate key; read-only calls get the foundation's refusal.

This branch contains the Power User foundation commits (feat/pu-mods-foundation); this PR's own change is tools/dbt-sql-graph.ts, api/sql-lineage.ts and test/altimate/dbt-sql-graph.test.ts.

How did you verify your code works?

bun test test/altimate/dbt-sql-graph.test.ts test/altimate/dbt-adapter-access.test.ts (44 tests, mocked endpoint and adapter) and bun typecheck, both from packages/opencode. Also run for real: altimate tool run dbt_sql_graph --allow-write on a built jaffle_shop copy against the Altimate backend (stg_customers: 4 nodes; orders: 9 nodes with a join and a group).

Cost side effects

One backend call and one warehouse metadata read (getBulkSchemaFromDB, parents only) per dbt_sql_graph call. Nothing runs per edit. The model's compile can run SQL only as the dbt integration already does for any compile.

Screenshots / recordings

Review follow-ups (not changed here)

Credentials are checked after the adapter starts; the shared API client has a fixed 15 s timeout and no abort signal (cancel is raced in the tool instead); the client drops the backend's 400 detail, so a parse failure shows only the status; manifest description/meta are sent to the backend as Power User does. The backend's response shape was verified against a local backend checkout and a live call.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR
  • I checked for cost side effects (model calls, queries or cloud resources that grow with user data) and described them, or wrote "none"

Changelog:

  • Added the dbt_sql_graph tool: a dbt model's CTEs, joins and filters as a graph.

Demo video (hosted)

P-01.mp4 — watch on Notion (Altimate workspace; recorded from the approved head of this PR).

🤖 Generated with Claude Code


Summary by cubic

Adds the dbt_sql_graph { model } tool, which compiles a model with the dbt adapter and returns its CTEs, joins, and filters as a graph of nodes and edges, and lays the shared foundation for adapter-backed Altimate tools.

  • The tool sends the compiled SQL to the Altimate backend's dbt/v3/sql_lineage endpoint, names the final select after the model (<model> (final select) when the SQL already has a node by that name), and ties each relation to its dbt unique id by name, plus schema and database when both sides give one. Nodes keep an id apart from their on-screen name, so two relations can share one, and joins and filters keep the SQL they were built from.
  • The graph merges each parent's manifest columns with the warehouse's reported columns, keyed by the adapter's folding case (Postgres, Redshift, and friends fold to lower case; quoted names stay as written), so the backend sees complete schemas.
  • Only SQL models are accepted: seeds, snapshots, and Python models are refused before anything compiles.
  • dbtAdapterFor is the single gate for adapter-backed tools: it refuses read-only calls, sessions in a different dbt project, and an adapter that didn't start, with a bounded wait that follows call aborts. A call cancelled at any point ends at once; refusals return as tool failures, and an abort during the backend call ends it at once.
  • AltimateApi.apiRequest posts to any backend endpoint with the stored credentials and a clear error naming the credentials file when missing.
  • Eight stubs (dbt_run_results, dbt_defer_state, dbt_map_relations, docs_share_comments, dbt_cost_estimate, dbt_health, dbt_docs_coverage, dbt_cte_profile) are exposed through the tool allow-list as not-yet-implemented placeholders.
  • The tool needs write permission and an Altimate key; each call costs one backend request and one warehouse metadata read of the model's parents only.

Written for commit 5bab957. Summary will update on new commits.

View guided diff Turn on auto-fix

hkaltai and others added 4 commits November 13, 2026 16:30
Nine tool stubs exposed through `altimate tool run` (dbt_run_results,
dbt_defer_state, dbt_map_relations, docs_share_comments, dbt_cost_estimate,
dbt_health, dbt_sql_graph, dbt_docs_coverage, dbt_cte_profile), an exported
`AltimateApi.apiRequest` that calls the backend with the stored credentials,
and `dbtAdapterFor`, the one gate every adapter-backed tool goes through:
it refuses read-only calls, other projects, and an adapter that did not start.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Compiles the model, reads its parents' columns from the warehouse's metadata, and asks the Altimate backend's sql_lineage endpoint; the graph's final select is named after the model and its relations are tied to their dbt nodes.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 117761ef-56c7-4b3a-92d0-027ed3a5e5be
Commits

Reviewing files that changed from the base of the PR and between bc8025b and 5bab957.

Files selected for processing: 15

  • packages/opencode/src/altimate/api/client.ts
  • packages/opencode/src/altimate/api/sql-lineage.ts
  • packages/opencode/src/altimate/tool-cli/allow-list.ts
  • packages/opencode/src/altimate/tools/dbt-adapter-access.ts
  • packages/opencode/src/altimate/tools/dbt-cost-estimate.ts
  • packages/opencode/src/altimate/tools/dbt-cte-profile.ts
  • packages/opencode/src/altimate/tools/dbt-defer-state.ts
  • packages/opencode/src/altimate/tools/dbt-docs-coverage.ts
  • packages/opencode/src/altimate/tools/dbt-health.ts
  • packages/opencode/src/altimate/tools/dbt-map-relations.ts
  • packages/opencode/src/altimate/tools/dbt-run-results.ts
  • packages/opencode/src/altimate/tools/dbt-sql-graph.ts
  • packages/opencode/src/altimate/tools/docs-share-comments.ts
  • packages/opencode/test/altimate/dbt-adapter-access.test.ts
  • packages/opencode/test/altimate/dbt-sql-graph.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown

👋 This PR was automatically closed by our quality checks.

Common reasons:

  • New GitHub account with limited contribution history
  • PR description doesn't meet our guidelines
  • Contribution appears to be AI-generated without meaningful review

If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you.

hkaltai and others added 2 commits November 13, 2026 17:09
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…fore compile, model-name collisions, models only

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

👋 This PR was automatically closed by our quality checks.

Common reasons:

  • New GitHub account with limited contribution history
  • PR description doesn't meet our guidelines
  • Contribution appears to be AI-generated without meaningful review

If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you.

@hkaltai

hkaltai commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

Review of this change (two independent reviewers, then a separate check of the fixes). Each finding and what happened to it, fixed in f6aed61:

Fixed

  • Column case — mergeColumns lower-cased everything unless it carried literal quote characters, so Postgres Foo/foo and Snowflake Foo/FOO merged into one column. It now follows dbt Power User's rule: a name the adapter would only keep when quoted keeps its case (adapter-aware, same regexes as isQuotedIdentifier).
  • Session id — session_id was only the SQL hash, so two sessions asking for the same SQL sent the same id. It is now <session id>-<md5 of the compiled SQL>, as Power User does.
  • Cancel before compile — an abort during parseManifest still compiled the model. The abort signal is now checked after the manifest and after the compile, before the warehouse read.
  • constructor / __proto__ columns — a warehouse column with an Object member's name hit the inherited property and wrote to Object.prototype. The merge now uses a Map.
  • Model name vs. CTE — a CTE or {{ this }} table named like the model (e.g. with customers as (...) in customers.sql) was overwritten by the model's own select and could form a cycle. The model's select is now <model> (final select) when the name is taken. Power User's remap has the same overwrite; this is a deliberate difference.
  • Seeds, snapshots, Python models — a name that resolved to one of those had its file compiled and sent. Only resource_type: model with a .sql path is accepted now.
  • Comment — formatSqlGraph no longer claims dependency order.
  • Tests — full model_info request with toEqual, both case families, the Object-member names, the name collision (CTE and source), refused node types, cancel during parse and compile, session id per session. dbt-adapter-access.test.ts now skips this tool in its placeholder loop.

Not changed, on purpose

  • Credentials are checked inside apiRequest, after the adapter has started and the model has compiled. Checking earlier is a cost nicety; left for a follow-up.
  • The backend fetch ignores the abort signal and has a fixed 15 s timeout. That is in the shared client (api/client.ts), not this change.
  • Node name vs. edge key, and two parents with the same alias: unconfirmed against the backend's real replies; left as is.
  • Column description/meta go to the backend with the compiled SQL: same as Power User.

Cost side effects are unchanged: one backend call and one warehouse metadata read per call.

@github-actions

Copy link
Copy Markdown

👋 This PR was automatically closed by our quality checks.

Common reasons:

  • New GitHub account with limited contribution history
  • PR description doesn't meet our guidelines
  • Contribution appears to be AI-generated without meaningful review

If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you.

# Conflicts:
#	packages/opencode/src/altimate/tools/dbt-sql-graph.ts
@github-actions

Copy link
Copy Markdown

👋 This PR was automatically closed by our quality checks.

Common reasons:

  • New GitHub account with limited contribution history
  • PR description doesn't meet our guidelines
  • Contribution appears to be AI-generated without meaningful review

If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you.

@github-actions

Copy link
Copy Markdown

👋 This PR was automatically closed by our quality checks.

Common reasons:

  • New GitHub account with limited contribution history
  • PR description doesn't meet our guidelines
  • Contribution appears to be AI-generated without meaningful review

If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you.

…chema and database, operation SQL, cancel during the backend call, refusal as failure

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

👋 This PR was automatically closed by our quality checks.

Common reasons:

  • New GitHub account with limited contribution history
  • PR description doesn't meet our guidelines
  • Contribution appears to be AI-generated without meaningful review

If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you.

@hkaltai

hkaltai commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

Review round (Claude + Codex, independent CLI runs) — findings and replies

All findings are fixed in 4a6dc20 unless marked otherwise.

# Finding (reviewer) Reply
1 MAJOR node name vs edge key identity: edges dangle, repeated relations collide (Codex; Claude as a comment) Confirmed against the backend producer (sql_visualization/utils.py: relation keys are db.name_<id>). Nodes now carry a unique id (the backend key) plus a display name; edges are [inputId, consumerId]. Plugin PR updated to match.
2 MAJOR relation→dbt mapping compared aliases to opaque keys (Codex); same-alias parents overwrite (Claude, comment) Match is now on the node's name (key as fallback), restricted to the parent's database and schema when both are known, for every occurrence; a source uses identifier || name. A relation two parents could both be is tied to neither (no order-dependent identity).
3 MAJOR cancel can't interrupt the in-flight backend request (both) The backend call is raced against the abort signal in the tool, so cancel returns at once; the shared client is untouched (its own 15 s bound still ends the request).
4 MAJOR operation nodes lose their SQL: backend sends expression, not sql (Codex) sql ?? expression ?? ""; types updated.
5 MAJOR read-only refusal reported as success, exit 0 (Claude) Refusal metadata now sets error, so the CLI/MCP report a failure.
6 MINOR no shape check on the backend reply (Claude) A reply without tableEdges/details is a clear error.
7 MAJOR tool entry point untested (Claude) Added tests for the refusal, the manifest-miss failure, cancel during the backend call, malformed reply, the backend's real node shapes, cross-schema/database parents, repeated occurrences, ambiguity. 44 tests pass with dbt-adapter-access; bun typecheck clean.

Attack-the-fix gate (fresh Codex and Claude processes) passed on the third run; the first two runs found the cross-database and ambiguity gaps, now fixed and tested.

Not changed (pre-existing / out of scope, for follow-up): credentials are checked after the adapter starts; the shared API client has a fixed 15 s timeout and no signal; manifest description/meta are sent to the backend as Power User does; toMatchObject in two new test assertions.

The backend's response shape was verified against a local backend checkout, not a deployed backend.

@github-actions

Copy link
Copy Markdown

👋 This PR was automatically closed by our quality checks.

Common reasons:

  • New GitHub account with limited contribution history
  • PR description doesn't meet our guidelines
  • Contribution appears to be AI-generated without meaningful review

If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you.

1 similar comment
@github-actions

Copy link
Copy Markdown

👋 This PR was automatically closed by our quality checks.

Common reasons:

  • New GitHub account with limited contribution history
  • PR description doesn't meet our guidelines
  • Contribution appears to be AI-generated without meaningful review

If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you.

@hkaltai
hkaltai marked this pull request as ready for review November 14, 2026 03:52
@hkaltai

hkaltai commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

review-loop: APPROVED at 4a6dc20

Confirm gate (fresh Claude + Codex, read-only, on the fix commit). Claude: APPROVED. Codex: one P2, stripAggFilter in native/dbt/project-lineage.ts miscounts a parenthesis inside a comment. That file is not in this PR's diff (it came from #1710 on main), so it is pre-existing and out of scope; noted for follow-up, not changed here. No defect found in this PR's changes.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 15 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

@kilo-code-bot

kilo-code-bot Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
packages/opencode/src/altimate/tools/dbt-adapter-access.ts 86 New adapter gate still duplicates dbt-lineage.ts's sessionProject() byte-for-byte and fromAdapter()'s start-wait/timeout/refusal block; dbt_lineage keeps its own copy, so the gate is not yet the single one it documents and fixes (abort ordering, timeout, project-mismatch rule) still have to land twice
Notes
  • Incremental review of 5bab9574 (delta 4a6dc209..5bab9574). All three prior findings on the changed lines are addressed: redshift added to LOWER_FOLDING with a case test, throwIfAborted() now runs before the read-only early return (with a test for the cancelled read-only call), and the backend-cancel test waits on a fetchLineage readiness signal instead of Bun.sleep(10).
  • Verified in the delta: throwIfAborted() before the read-only branch matches dbt-lineage.ts:223-227 (fromAdapter also aborts before its readOnly return), so the two gate copies now agree on cancellation; the abort throw is consistent with the existing non-read-only cancellation path (dbtAdapterFor already rethrows when signal.aborted); the Redshift expectation ["FOO","foo"] follows from columnKey (uppercase → treated as quoted → kept, lowercase → folded).
  • Existing inline comments on dbt-sql-graph.ts:78 (Redshift) and dbt-adapter-access.ts:28/30 (abort/write gate) were checked and not repeated; the dbt_run_results placeholder comment is intentional per the author reply.
  • Tests were not executed in this review (read-only mode); the PR reports 44 passing tests and a clean typecheck.
  • Not verified here (no dbt/warehouse): whether getAdapterType() is always lower-case — the new redshift entry is compared case-sensitively, and register.ts forwards the adapter's raw string.
Files Reviewed (15 files; 4 re-reviewed in this delta)
  • packages/opencode/src/altimate/tools/dbt-adapter-access.ts - 1 suggestion (carried forward)
  • packages/opencode/src/altimate/tools/dbt-sql-graph.ts - no new issues
  • packages/opencode/test/altimate/dbt-adapter-access.test.ts - no issues
  • packages/opencode/test/altimate/dbt-sql-graph.test.ts - no issues
  • packages/opencode/src/altimate/api/client.ts - unchanged since prior review
  • packages/opencode/src/altimate/api/sql-lineage.ts - unchanged since prior review
  • packages/opencode/src/altimate/tool-cli/allow-list.ts - unchanged since prior review
  • packages/opencode/src/altimate/tools/dbt-cost-estimate.ts - unchanged since prior review
  • packages/opencode/src/altimate/tools/dbt-cte-profile.ts - unchanged since prior review
  • packages/opencode/src/altimate/tools/dbt-defer-state.ts - unchanged since prior review
  • packages/opencode/src/altimate/tools/dbt-docs-coverage.ts - unchanged since prior review
  • packages/opencode/src/altimate/tools/dbt-health.ts - unchanged since prior review
  • packages/opencode/src/altimate/tools/dbt-map-relations.ts - unchanged since prior review
  • packages/opencode/src/altimate/tools/dbt-run-results.ts - unchanged since prior review
  • packages/opencode/src/altimate/tools/docs-share-comments.ts - unchanged since prior review

Fix these issues in Kilo Cloud

Previous Review Summary (commit 4a6dc20)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 4a6dc20)

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 2
Issue Details (click to expand)

SUGGESTION

File Line Issue
packages/opencode/src/altimate/tools/dbt-adapter-access.ts 84 New adapter gate duplicates dbt-lineage.ts's sessionProject() byte-for-byte and its start-wait/timeout/refusal block; dbt_lineage still runs its own copy, so the gate is not yet the single one it documents and fixes must land twice
packages/opencode/test/altimate/dbt-sql-graph.test.ts 617 The backend-cancel test waits with a fixed Bun.sleep(10) instead of a readiness signal (explicitly disallowed in packages/opencode/test/AGENTS.md); on a slow host the abort can land before fetchLineage, so the test passes without exercising untilAborted
Notes
  • Existing comments on dbt-sql-graph.ts:78 (Redshift missing from LOWER_FOLDING) and on dbt-adapter-access.ts:28 (write-gate/abort on the read-only early return) were checked and not repeated. On the write-gate point: dbt_sql_graph is only registered in the CLI/MCP allow-list (tool-cli/allow-list.ts), not the agent tool registry, and both of those set extra.forceReadOnly when writes are not enabled, so the shipped call paths are gated.
  • Verified in changed code and found no issue: no bare await of an Effect value; the abort checks before compile/warehouse/backend reads are ordered so no request can start after an abort; mergeColumns uses a Map so __proto__/constructor column names cannot touch built-ins; every edge id emitted by remapSqlLineage exists in nodes for the shapes tested; parent→dbt mapping is order-independent (ambiguous claims dropped); cost stays one backend call plus one parents-only metadata read per invocation.
  • Not verified (no dbt/warehouse here): the real dbt-integration adapter method signatures (getNonEphemeralParents, getBulkSchemaFromDB, sourceMetaMap), and whether getAdapterType() is always lower-case.
  • Tests were not executed in this review (read-only mode); the PR reports 44 passing tests and a clean typecheck.
Files Reviewed (15 files)
  • packages/opencode/src/altimate/api/client.ts - no issues
  • packages/opencode/src/altimate/api/sql-lineage.ts - no issues
  • packages/opencode/src/altimate/tool-cli/allow-list.ts - no issues
  • packages/opencode/src/altimate/tools/dbt-adapter-access.ts - 1 suggestion
  • packages/opencode/src/altimate/tools/dbt-cost-estimate.ts - no issues
  • packages/opencode/src/altimate/tools/dbt-cte-profile.ts - no issues
  • packages/opencode/src/altimate/tools/dbt-defer-state.ts - no issues
  • packages/opencode/src/altimate/tools/dbt-docs-coverage.ts - no issues
  • packages/opencode/src/altimate/tools/dbt-health.ts - no issues
  • packages/opencode/src/altimate/tools/dbt-map-relations.ts - no issues
  • packages/opencode/src/altimate/tools/dbt-run-results.ts - no issues
  • packages/opencode/src/altimate/tools/dbt-sql-graph.ts - no new issues
  • packages/opencode/src/altimate/tools/docs-share-comments.ts - no issues
  • packages/opencode/test/altimate/dbt-adapter-access.test.ts - no issues
  • packages/opencode/test/altimate/dbt-sql-graph.test.ts - 1 suggestion

Fix these issues in Kilo Cloud


Reviewed by deepseek-v4.1-flash-1017 · Input: 71.2K · Output: 11.2K · Cached: 705.3K

Review guidance: REVIEW.md from base branch main (truncated)

@github-actions

Copy link
Copy Markdown

👋 This PR was automatically closed by our quality checks.

Common reasons:

  • New GitHub account with limited contribution history
  • PR description doesn't meet our guidelines
  • Contribution appears to be AI-generated without meaningful review

If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you.

…nly call is cancelled not refused, the cancel test waits for the backend call

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

👋 This PR was automatically closed by our quality checks.

Common reasons:

  • New GitHub account with limited contribution history
  • PR description doesn't meet our guidelines
  • Contribution appears to be AI-generated without meaningful review

If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you.

1 similar comment
@github-actions

Copy link
Copy Markdown

👋 This PR was automatically closed by our quality checks.

Common reasons:

  • New GitHub account with limited contribution history
  • PR description doesn't meet our guidelines
  • Contribution appears to be AI-generated without meaningful review

If you believe this was a mistake, please open an issue explaining your intended contribution and a maintainer will help you.

@hkaltai

hkaltai commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

review-loop: APPROVED at 5bab957

Verify-only gate on the review-fix commit 5bab9574c8 (Redshift folding, cancel before the read-only refusal, readiness signal in the cancel test): fresh read-only Claude and Codex reviews both approved. The two declined threads (write gate matching dbt_lineage, the dbt_run_results placeholder) and the shared-gate follow-up are answered in their threads. Follow-up for dbt_lineage: reuse dbtAdapterFor's helpers; the stripAggFilter comment-parenthesis case noted earlier is also still open.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant