Repository navigation
feat: request changes on workspace review requests #1755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f8ee35a
feat: request changes on workspace review requests
saravmajestic 080f4b4
feat: tell Claude Code and Codex sessions about requests sent back fo…
saravmajestic becba29
fix: a rule the author replaced or withdrew is not shown as closed by…
saravmajestic 9776f9d
fix: keep rule proposals closed from here consistent with pulls
saravmajestic e697d10
feat: a sent-back skill or knowledge request shows its whole comment …
saravmajestic a8f1f9c
test: give the learn CLI's skill-publish mocks `publishErrorCode`
saravmajestic 6d31881
fix: rule withdraw and resend stay right when a pull or another accou…
saravmajestic 0afde44
fix: a pull that saw a resend decided does not reopen it; resend reco…
saravmajestic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preserve closure records during same-scope resets.
If one pull remains in flight after a withdrawal, another pull can fail with
forbiddenand callcleared(state, { keepOutbox: true }). This reset retainsscopeandclose_seq, but removesclosed_locally.The older successful response then passes
ownedByand the revision check. Its empty fence allows the withdrawn proposal back intomy_pendinguntil another pull corrects it.When
keepOutboxis true, preserveclosed_locallyalongsideclose_seq. Do not carry these records into another account or workspace.