Repository navigation
Docs: graph_batch docstrings name the churn limitation - #98
Merged
Merged
Conversation
Both backends' graph_batch() docstrings now carry the same short Note: graph_batch() is recommended for bulk loads, but when it is called again and again on types that also see deletes, each flush writes its edge records onto new pages and never reuses freed space, so the edge bucket grows (ArcadeData/arcadedb#10746). For that workload write the edges with SQL CREATE EDGE or Vertex.new_edge inside db.transaction(). The Note points to the bulk-loads docs page (section "Known limitation: graph batches next to deletes", PR #97). Docstrings only, no behaviour change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
graph_batch()docstrings still called the batch "the recommended path for bulk graph loading" with no caveat. PR #97 added the section "Known limitation: graph batches next to deletes" to the bulk-loads page: eachgraph_batch()flush writes its edge records onto new pages and never reuses the space that deletes freed, so the edge bucket grows when a workload callsgraph_batch()again and again on a type that also sees deletes (ArcadeData/arcadedb#10746). One-off bulk loads are not affected.This adds the same short
Note:paragraph to thegraph_batch()docstring of both backends:Database.graph_batchinsrc/arcadedb/core.py(JVM) andNativeDatabase.graph_batchinsrc/arcadedb/_native/database.py(native). The note says the batch is recommended for bulk loads, names the growth under repeated flushes next to deletes, points to SQLCREATE EDGEorVertex.new_edgeinsidedb.transaction()for that workload, and points to the bulk-loads docs page.Docstrings only, no behaviour change. The edit sits in the
graph_batchdocstring and nowhere else incore.py, so it does not touch thelookup_by_keydocstrings that #96 edits.Checked locally:
black --check(26.10.1) andisort --profile black --check-onlyon both files, andpython3 scripts/check_no_embedded_name.py --root ..🤖 Generated with Claude Code