Repository navigation
Conversation
SvelteKit 3 no longer reads svelte.config.js, and adapter-vercel 7 requires Kit 3, so both are upgraded together. - Pin @sveltejs/kit 3.1.0 and @sveltejs/adapter-vercel 7.0.1 - Move the svelte.config.js options into sveltekit() in vite.config.ts; pass dynamicCompileOptions directly because Kit 3 removed config.vitePlugin (the sv migrate output still nests it there) - Extend $app/tsconfig, which provides the compiler options that were set by hand, and keep $app/types in the overridden "types" build, unit tests and lint pass. svelte-check reports 20 errors that belong to the next phase (type export moves, $app/environment, $app/stores, resolve() typings, and generic Actions params). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fix the svelte-check errors left by the Kit 3 upgrade and move the
remaining Kit 2 APIs to their Kit 3 forms.
- Import Handle from @sveltejs/kit/hooks and SubmitFunction from
$app/forms; import Actions from ./$types where params are used
- Replace $app/environment with $app/env, including the test mocks
- Move KanbanBoard from $app/stores to $app/state and from
replaceState() to a shallow goto(), so filter changes keep the board's
local state; widen the kanban URL helpers to accept the read-only
page.url
- Type buildWorkbooksUrl() as a /workbooks route with search so
resolve() accepts it, use { replace: true } instead of the deprecated
replaceState option, and drop the @ts-expect-error comments that
Kit 3's route types no longer need
- Add E2E tests for keeping the kanban state while replacing the filter
URL and for restoring saved workbook filters without a history entry
svelte-check, lint, unit tests, build, and the related E2E specs pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pin the SvelteKit 3 behavior of form actions, logout, session cookies and error pages before the release. - signin: keep form values after a failed enhanced login, return the fail() status (400) for an enhanced submission, land on home when logging out without a session, and keep the session cookie attributes - workbook_edit: keep the nested workbook tasks after a failed edit - account_transfer: reject a non-admin user (page and direct POST) and show the validation message for identical account names - error_pages: render the 404 and 403 error pages The fail() status and logout tests fail on SvelteKit 2, so they detect the Kit 3 behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- workbook_edit: delete a task row before the failed submission, so the test fails if the table falls back to the workbook's original tasks (confirmed with a temporary onUpdate mutation) - workbook_order: rename the shallow-routing test to what it checks (no data reload and no history entry) - architecture.md: separate the filename and server/ directory rules for server-only modules, and split the subpath imports section into use / don't use / extensions with OK and NG examples Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The subpath imports section still assumed Kit 2, where lint was the only
guard against $lib. On Kit 3, $lib fails in every form (vi.mock included,
via module_removed_lib), while vi.mock('$features/...') is silently
ignored, which is why the rg sweep remains.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 55.56% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 21 files. (15 skipped:… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check タイトルはSvelteKit v3とVercelアダプターv7への移行を明確に示しており、変更内容の中心と一致しています。 Linked Issues check 直接リンクされた #4192は SvelteKit 2 から 3 への移行です。package.jsonは@sveltejs/kitを3.1.0、@sveltejs/adapter-vercelを7.0.1に更新しています。vite.config.ts、tsconfig.json、src/hooks.server.ts、$app/envと `$…Out of Scope Changes check 変更は #4192の移行に関連しています。依存関係、Vite と TypeScript 設定、Kit 3 API の呼び出し、ルート型、認証・フォーム・ナビゲーションの回帰テスト、移行後の開発者向け文書を更新しています。svelte.config.jsの移行に伴う削除と Vercel 設定のvite.config.tsへの移動も同じ目的に含まれます。無関係な機能追加または独立した修…Full details: Linked Issues check
-
Explanation
直接リンクされた
#4192は SvelteKit 2 から 3 への移行です。package.jsonは@sveltejs/kitを3.1.0、@sveltejs/adapter-vercelを7.0.1に更新しています。vite.config.ts、tsconfig.json、src/hooks.server.ts、$app/envと$app/stateの利用、Kit 3 の型とルート API に合わせて実装を更新しています。移行後のsvelte-check、lint、単体テスト、build、関連 E2E の成功も要約に示されています。E2E とドキュメントはフォーム、認証、エラーページ、ナビゲーションなどの Kit 3 回帰を検証します。
Full details: Out of Scope Changes check
-
Explanation
変更は
#4192の移行に関連しています。依存関係、Vite と TypeScript 設定、Kit 3 API の呼び出し、ルート型、認証・フォーム・ナビゲーションの回帰テスト、移行後の開発者向け文書を更新しています。svelte.config.jsの移行に伴う削除と Vercel 設定のvite.config.tsへの移動も同じ目的に含まれます。無関係な機能追加または独立した修正は、提供された変更要約から確認できません。
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 55.56% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 21 files. (15 skipped: 15 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
Warning
Some tools did not complete. Review the errors below.
🔧 ESLint
-
If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
ESLint install timed out. The project may have too many dependencies for the sandbox.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #4192
Summary by CodeRabbit