Repository navigation
engines: node >=22.5.0, the floor the product actually has - #1866
Merged
Merged
Conversation
The bundle writes graph.sqlite through node:sqlite, which ships since Node 22.5; on an older Node the guarded import degrades the bundle to CSV and every query surface reads graph.sqlite, so nothing answers. README.md and CI already say 22.5 / 22 — the manifests still said >=18.0.0, so a package manager that honors engines let Node 18 install something that cannot run. Both manifests now declare >=22.5.0, and the C# suite README's '18 or newer' line says 22.5 like everything else. Fixes #1865. Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
October 8, 2026 17:55
swapnilpaliwal-sd
added a commit
that referenced
this pull request
Oct 8, 2026
The graph is written with node:sqlite, which Node ships without a flag only from 22.13 (and 23.4). #1866 set engines to >=22.5, but on 22.5-22.12 the module needs --experimental-sqlite: on Node 22.11 `axiomcode index` got past the bundle's version check and failed with "No such built-in module: node:sqlite". - bin/axiomcode.js stops at once on an older Node: "axiomcode needs Node 22.13 or newer (it writes the graph with node:sqlite); this is Node X". Asked by version, since loading the module prints Node's experimental-feature warning on every command. - sqliteAvailable() asks the module, not the version. - engines.node >=22.13.0 in both package.json files; CI and the C# suite README say 22.13. Checked on Node 22.11 and 23.3 (refused, module absent) and 22.13 and 23.4 (run, module present). Co-authored-by: axiomcode-bot[bot] <334110751+axiomcode-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #1865: the manifests declared
engines: { node: ">=18.0.0" }while the product needs Node ≥ 22.5.Why
graph/bundle/write.tswritesgraph.sqlitethroughnode:sqlite, which ships since Node 22.5. On an older Node the guarded import degrades the bundle to CSV — and every query surface (impact/path/tests, the MCP server, the hooks) readsgraph.sqlite, so the product does not answer. README.md already states ≥ 22.5 (badge + Requirements) and CI runs Node 22; the manifests were the stragglers, so a package manager honoringengineslet Node 18 install something that cannot run.How
package.jsonandparser/package.json:engines.node→>=22.5.0.graph/test/csharp/README.md: the "18 or newer" line now says 22.5.Note: the base (not the default branch) will not auto-close #1865 on merge; it gets closed manually after.
🤖 Generated with Claude Code