[AutoPR azure-mgmt-fileshares]-generated-from-SDK Generation - Python-7024674 by azure-sdk-automation[bot] · Pull Request #49521 · Azure/azure-sdk-for-python

azure-sdk-automation · 2026-10-13T19:12:19Z

SDK generation details

Note

This pull request was generated automatically.

Detail	Value
TypeSpec source	`specification/fileshares/resource-manager/Microsoft.FileShares/FileShares/tspconfig.yaml` at `cec8aac`
Pipeline run	SDK Generation #7024674
Release plan	Release plan #36883
Submitted by	`jlindamood@microsoft.com`

Important

Complete the SDK release prerequisites before release.

…FileShares/FileShares/tspconfig.yaml', API Version: 2026-09-01, SDK Release Type: stable, and CommitSHA: 'cf4aa9847c9ac23bbe7c05c2c89b17ba10de9648' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6952245 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.

azure-pipelines · 2026-10-13T19:13:01Z

Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

…FileShares/FileShares/tspconfig.yaml', and CommitSHA: '4f84812320680da54d6dd0d0472ad8981618a922' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=7016573 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.

The recordings were made at 2026-06-01, so playback failed after the 2026-09-01 regeneration. Re-record all hand-written tests live against the canary endpoint (eastus2euap) and update the assets tag. Point the live-only CRUD test at the same canary defaults as the other tests, since 2026-09-01 is only in the canary manifest. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

🟡 Changes recommended

The API-version documentation incorrectly advertises support for None, which causes get_limits() to fail, and the changelog omits the Python minimum-version increase from 3.9 to 3.10.

2 open issues

What changed in this PR

Regenerates azure-mgmt-fileshares for API version 2026-09-01 and prepares the stable 1.0.0 release.

Changes:

Adds managed identity, encryption, scale mode, HDD tier, and redundancy-conversion support.
Updates generated clients, request types, examples, and release metadata; raises the minimum Python version to 3.10.
Moves CRUD test defaults to the canary environment and updates recorded assets.

Paths below are relative to sdk/fileshares/azure-mgmt-fileshares/. Generated samples and tests are listed for completeness but excluded from detailed review under repository guidance.

File	Description
`tsp-location.yaml`	Pins the updated TypeSpec source commit.
`tests/test_fileshares_crud.py`	Uses canary endpoint and resource defaults.
`README.md`	Updates authentication terminology to Microsoft Entra.
`pyproject.toml`	Marks the package stable and requires Python 3.10+.
`generated_tests/test_file_shares_mgmt_informational_operations_operations.py`	Expands provisioning request fields.
`generated_tests/test_file_shares_mgmt_informational_operations_operations_async.py`	Mirrors async provisioning request changes.
`generated_tests/test_file_shares_mgmt_file_shares_operations.py`	Adds new properties and conversion test stubs.
`generated_tests/test_file_shares_mgmt_file_shares_operations_async.py`	Mirrors async properties and conversion stubs.
`generated_samples/private_link_resources_list_by_file_share.py`	Updates source-version comment only.
`generated_samples/private_link_resources_get.py`	Updates source-version comment only.
`generated_samples/private_endpoint_connections_list_by_file_share.py`	Updates source-version comment only.
`generated_samples/private_endpoint_connections_get.py`	Updates source-version comment only.
`generated_samples/private_endpoint_connections_delete.py`	Updates source-version comment only.
`generated_samples/private_endpoint_connections_create.py`	Updates source-version comment only.
`generated_samples/operations_list_minimum_set_gen.py`	Updates source-version comment only.
`generated_samples/operations_list_maximum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_shares_update_maximum_set_gen.py`	Adds identity and encryption inputs.
`generated_samples/file_shares_start_redundancy_conversion_maximum_set_gen.py`	Adds a redundancy-conversion example.
`generated_samples/file_shares_list_by_subscription_minimum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_shares_list_by_subscription_maximum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_shares_list_by_parent_minimum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_shares_list_by_parent_maximum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_shares_get_redundancy_conversion_status_minimum_set_gen.py`	Adds a conversion-status example.
`generated_samples/file_shares_get_redundancy_conversion_status_maximum_set_gen.py`	Adds a conversion-status example.
`generated_samples/file_shares_get_maximum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_shares_delete_maximum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_shares_create_or_update_maximum_set_gen.py`	Adds identity, encryption, and scale mode.
`generated_samples/file_shares_check_name_availability_minimum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_shares_check_name_availability_maximum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_share_snapshot_update_maximum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_share_snapshot_list_minimum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_share_snapshot_list_maximum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_share_snapshot_get_maximum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_share_snapshot_delete_maximum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_share_snapshot_create_or_update_maximum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_share_get_usage_data_minimum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_share_get_usage_data_maximum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_share_get_provisioning_recommendation_minimum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_share_get_provisioning_recommendation_maximum_set_gen.py`	Adds offer-selection inputs.
`generated_samples/file_share_get_limits_minimum_set_gen.py`	Updates source-version comment only.
`generated_samples/file_share_get_limits_maximum_set_gen.py`	Updates source-version comment only.
`CHANGELOG.md`	Lists additions for version 1.0.0.
`azure/mgmt/fileshares/types.py`	Adds typed dictionary request definitions.
`azure/mgmt/fileshares/models/_models.py`	Adds models and resource properties.
`azure/mgmt/fileshares/models/_enums.py`	Adds encryption, identity, scale, and conversion enums.
`azure/mgmt/fileshares/models/__init__.py`	Exports new models and enums.
`azure/mgmt/fileshares/aio/operations/_operations.py`	Updates async operations, typing, and paging headers.
`azure/mgmt/fileshares/aio/_configuration.py`	Advances the async default API version.
`azure/mgmt/fileshares/aio/_client.py`	Updates async client documentation and typing imports.
`azure/mgmt/fileshares/_version.py`	Sets package version to 1.0.0.
`azure/mgmt/fileshares/_utils/serialization.py`	Refreshes generated serialization helpers.
`azure/mgmt/fileshares/_utils/model_base.py`	Refreshes model serialization and deserialization.
`azure/mgmt/fileshares/_configuration.py`	Advances the synchronous default API version.
`azure/mgmt/fileshares/_client.py`	Updates client documentation and typing imports.
`assets.json`	Points to updated test recordings.
`apiview-properties.json`	Updates cross-language API mappings.
`api.metadata.yml`	Adds API snapshot metadata.
`_metadata.json`	Records updated API and generator versions.

_{Review effort: Balanced}

…lists The tests created shares in a resource group shared with other test suites, and listing by subscription returns every share in the shared test subscription, so recordings captured unrelated resources' names, IDs and host names. - Default FILESHARES_TEST_RG to azsdk-python-fileshares-rg, used only by these tests. - conftest.py: while recording, keep only that resource group's shares in recorded file share list responses. - Re-recorded all tests against the canary endpoint and updated the assets tag. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

🔵 Needs a closer look

Client documentation incorrectly advertises support for api_version=None, which causes operations to fail, and release notes omit the new Python 3.10+ requirement.

2 open issues

2 previously missed issues

In code that hasn't changed since last review

Document the dropped Python 3.9 support

sdk/fileshares/azure-mgmt-fileshares/CHANGELOG.md:5

This release raises requires-python from 3.9 to 3.10, but the new 1.0.0 changelog only lists added features. Please add an entry explicitly stating that Python 3.9 is no longer supported so users can identify the compatibility change before upgrading.

Document the async client's actual API version default

sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/aio/_client.py:71

The async client also advertises api_version=None, but its configuration preserves that value and operation validation rejects it; for example, start_redundancy_conversion raises a ValueError before sending a request. Please regenerate the documentation with the actual 2026-09-01 default and remove None from the supported values unless the fallback is implemented.

_{Review effort: Balanced}

API version 2026-09-01 is not yet available in the public ARM manifest, so release this as a beta instead of the first stable release: version 1.0.0b2, 'Development Status :: 4 - Beta' and is_stable = false. A stable 1.0.0 follows once 2026-09-01 is publicly available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

🟡 Changes recommended

The API metadata incorrectly labels prerelease 1.0.0b2 as stable 1.0.0, while documentation omits dropped Python 3.9 support and advertises an unsupported None API version.

3 open issues

_{Review effort: Balanced}

…a and changelog fixes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

🔵 Needs a closer look

The generated client documentation incorrectly advertises api_version=None as supported, although explicitly passing it causes operations such as get_limits to raise ValueError instead of using the default.

1 open issue

Document omission as the default API version instead of supporting None

2 resolved since last review

_{Review effort: Balanced}

github-actions · 2026-11-01T17:03:11Z

[Pilot] PR Pipeline Failure Analysis

What failed

Azure Pipeline build 7024664 (job: python - pullrequest, task: "Create APIView if API has changes") failed in the Detect-Api-Changes.ps1 PowerShell step with:

PowerShell exited with code '1'.
The term 'System.PullRequest.PullRequestNumber' is not recognized as a name of a cmdlet, function, script file, or executable program.

Relevant pipeline output

[command]/usr/bin/pwsh -NoLogo -NoProfile -NonInteractive -Command . '/mnt/vss/_work/_temp/cd625aa5-6c4f-4a42-a86c-b82ecd0aae07.ps1'
System.PullRequest.PullRequestNumber: /mnt/vss/_work/_temp/cd625aa5-6c4f-4a42-a86c-b82ecd0aae07.ps1:3
Line |
   3 |  ... 664 -PullRequestNumber $(System.PullRequest.PullRequestNumber) -RepoF ...
     |                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | The term 'System.PullRequest.PullRequestNumber' is not recognized as a
     | name of a cmdlet, function, script file, or executable program. Check
     | the spelling of the name, or if a path was included, verify that the
     | path is correct and try again.

##[error]PowerShell exited with code '1'.

Root cause

The step is defined in the shared pipeline template eng/common/pipelines/templates/steps/detect-api-changes.yml (line 22), which invokes Detect-Api-Changes.ps1 with -PullRequestNumber $(System.PullRequest.PullRequestNumber). Azure Pipelines did not substitute the $(System.PullRequest.PullRequestNumber) variable macro before the PowerShell script ran — it was passed through literally. PowerShell then tried to interpret the raw, unquoted token System.PullRequest.PullRequestNumber as a positional/command argument, producing "not recognized as a name of a cmdlet" and failing the step.

This indicates the System.PullRequest.PullRequestNumber predefined variable was not available/populated in this build's context, rather than an issue with any file changed in this PR. None of the 62 files modified in this PR touch eng/common/pipelines/ or the Detect-Api-Changes.ps1 script — the failure is in a shared engineering pipeline template unrelated to the azure-mgmt-fileshares SDK generation changes in this PR.

Recommended next steps

Re-run/retry the python - pullrequest pipeline — this is often transient when the System.PullRequest.* variable group isn't populated for a particular trigger/run.
If it recurs across multiple PRs, file an issue against eng/common/pipelines/templates/steps/detect-api-changes.yml to add a guard (e.g., quote the variable or skip the step when System.PullRequest.PullRequestNumber is empty) so a missing variable doesn't crash the step.
See https://aka.ms/ci-fix

Copilot detected the failing pipeline and generated the analysis above. To have it attempt a fix automatically, reply with @copilot please fix the failing pipeline on this PR.

Generated by Pipeline Analysis Next Steps · copilot · sonnet50 · 33.3 AIC · ⌖ 0.561 AIC · ⊞ 8.9K · ◷

…FileShares/FileShares/tspconfig.yaml', and CommitSHA: 'cec8aac5df80e978dc33d830a61398da2102813e' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=7024674 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.

Copilot

🔵 Needs a closer look

Service-owner confirmation is needed before the stable 1.0.0 release because the changed CRUD-test comment identifies API 2026-09-01 as canary-only, and the supplied evidence does not establish production ARM availability.

No open issues 🎉

1 resolved since last review

Document omission as the default API version instead of supporting None

_{Review effort: Balanced}

James Lindamood (jlindamood) · 2026-11-01T17:12:49Z

/azp run python - pullrequest

azure-pipelines · 2026-11-01T17:13:03Z

Azure Pipelines: Successfully started running 1 pipeline(s).

azure-sdk-automation Bot changed the title ~~[AutoPR azure-mgmt-fileshares]-generated-from-SDK Generation - Python-6952245~~ [AutoPR azure-mgmt-fileshares]-generated-from-SDK Generation - Python-7016573 Oct 29, 2026

azure-sdk-automation Bot added the auto-release When merged to main, release pipelines for this PR's changed packages trigger automatically. label Oct 29, 2026

James Lindamood (jlindamood) marked this pull request as ready for review October 30, 2026 19:01

Copilot AI balanced review requested due to automatic review settings October 30, 2026 19:01

James Lindamood (jlindamood) requested review from a team, Chenxi Jiang (ChenxiJiang333) and Yuchao Yan (msyyc) as code owners October 30, 2026 19:01

Copilot started reviewing on behalf of James Lindamood (jlindamood) October 30, 2026 19:01

View session

Copilot AI reviewed Oct 30, 2026

View reviewed changes

Comment thread sdk/fileshares/azure-mgmt-fileshares/CHANGELOG.md Resolved

Comment thread sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/_client.py Resolved

Copilot AI balanced review requested due to automatic review settings October 30, 2026 21:35

Copilot started reviewing October 30, 2026 21:37

View session

Copilot AI reviewed Oct 30, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 30, 2026 22:17

Copilot started reviewing October 30, 2026 22:19

View session

Copilot AI reviewed Oct 30, 2026

View reviewed changes

Comment thread sdk/fileshares/azure-mgmt-fileshares/api.metadata.yml Resolved

[fileshares] Sanitize operation identifier header, re-record; metadat…

6cee19c

…a and changelog fixes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI balanced review requested due to automatic review settings October 31, 2026 04:27

Copilot started reviewing October 31, 2026 04:29

View session

Copilot AI reviewed Oct 31, 2026

View reviewed changes

azure-sdk-automation Bot changed the title ~~[AutoPR azure-mgmt-fileshares]-generated-from-SDK Generation - Python-7016573~~ [AutoPR azure-mgmt-fileshares]-generated-from-SDK Generation - Python-7024674 Nov 1, 2026

Copilot AI balanced review requested due to automatic review settings November 1, 2026 17:05

Copilot started reviewing November 1, 2026 17:07

View session

Copilot AI reviewed Nov 1, 2026

View reviewed changes

Navigation Menu

Repository navigation

[AutoPR azure-mgmt-fileshares]-generated-from-SDK Generation - Python-7024674 - #49521

[AutoPR azure-mgmt-fileshares]-generated-from-SDK Generation - Python-7024674#49521
azure-sdk-automation[bot] wants to merge 7 commits into
mainfrom
sdkauto/azure-mgmt-fileshares-6952245

azure-sdk-automation Bot commented Oct 13, 2026 •

edited

Loading

Uh oh!

azure-pipelines Bot commented Oct 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Nov 1, 2026

What failed

Root cause

Recommended next steps

Uh oh!

Copilot AI left a comment

Uh oh!

James Lindamood (jlindamood) commented Nov 1, 2026

Uh oh!

azure-pipelines Bot commented Nov 1, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

azure-sdk-automation Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK generation details

Uh oh!

azure-pipelines Bot commented Oct 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Nov 1, 2026

What failed

Root cause

Recommended next steps

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

James Lindamood (jlindamood) commented Nov 1, 2026

Uh oh!

azure-pipelines Bot commented Nov 1, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

azure-sdk-automation Bot commented Oct 13, 2026 •

edited

Loading