Skip to content

Fix two typos in oauth2cli/oauth2.py #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ernest (its-ernest) wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix two typos in oauth2cli/oauth2.py #972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions msal/oauth2cli/oauth2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ def _obtain_token( # The verb "obtain" is influenced by OAUTH2 RFC 6749
raw = self.client_assertion
_data["client_assertion"] = encoder(raw)

_data.update(self.default_body) # It may contain authen parameters
_data.update(self.default_body) # It may contain authentication parameters
_data.update(data or {}) # So the content in data param prevails
_data = {k: v for k, v in _data.items() if v} # Clean up None values

Expand Down Expand Up @@ -686,7 +686,7 @@ def obtain_token_by_browser(
:return: Same as :func:`~obtain_token_by_auth_code_flow()`
"""
if auth_code_receiver: # Then caller already knows the listen port
return self._obtain_token_by_browser( # Use all input param as-is
return self._obtain_token_by_browser( # Use all input params as-is
auth_code_receiver, redirect_uri=redirect_uri, **kwargs)
# Otherwise we will listen on _redirect_uri.port
_redirect_uri = urlparse(redirect_uri or "http://127.0.0.1:0")
Expand Down