Repository navigation
Discover: proportional model list width (1.0.2) - #2
Merged
Merged
Conversation
…trary start (1.0.2) HSplitView ignores idealWidth and keeps whatever divider position it starts with, so in large windows the model list stayed at its minimum (names truncated) while the detail pane, whose content is capped at 760 pt, took all extra space. ResizableSplit gives the list 40% of the area (min 380, detail min 400), keeps the proportion on resize, and remembers the dragged position (validated from user defaults). Header labels no longer wrap at narrow widths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In large windows the Discover model list stayed at its minimum, about 380 pt, so model names and authors were truncated. Meanwhile the detail pane, whose content is capped at 760 pt, took all the extra width.
HSplitView(NSSplitView) ignoresidealWidthand keeps whatever divider position it starts with, so the split depended on how the window reached its size.Fix
ResizableSplit: the list takes 40% of the Discover area, with minimums of 380 for the list and 400 for the detail pane. The proportion is kept on resize.@AppStorageand validated on read (finite, between 0 and 1).Verification
Snapshots at 2000×1160 (list about 700 pt, matching the requested mockup), 1280×820 and 1060×692 (list at its 380 minimum, names readable, header on one line).
swift test: 94 tests passed.🤖 Generated with Claude Code