Skip to content

ci: GPUI localization integration check (do not merge) - #3431

Closed
richiemcilroy wants to merge 17 commits into
mainfrom
ci/i18n-integration-062
Closed

richiemcilroy wants to merge 17 commits into
mainfrom
ci/i18n-integration-062

Conversation

@richiemcilroy

Copy link
Copy Markdown
Member

Integration check for the four GPUI localization PRs (#3424 #3423 #3422 #3428) merged together on top of main after #2987. Not for merge: each PR lands on its own with the same conflict resolutions, and this branch exists so the combined tree gets one full CI run.

Conflict resolutions:

  • settings_window.rs: Update app and tray menus for macOS #2987 added an UpdateStatus::Checking row label; it is now settings.sidebar.checking_for_updates, translated in all seven catalogs and pinned in the settings surface test.
  • Locale catalogs: each PR only appends sections, so every catalog is main plus each PR's appended block. A script confirms every catalog has exactly main's keys plus each PR's added keys, with identical values.
  • i18n/mod.rs and i18n/tests.rs: all four surface test modules and filters, each module behind #[cfg(test)].

@vercel

vercel Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cap-status Ready Ready Preview Oct 26, 2026 8:01pm UTC

@richiemcilroy

Copy link
Copy Markdown
Member Author

Integration check done: the four i18n PRs carry this exact merge chain (verified catalogs, 1496 GPUI tests on macOS, full CI). Closing; the branch stays as #3434's base until those land.

This branch was successfully deployed

2 active deployments
Preview – cap-web — c08865cc Deployed Oct 26, 2026 by vercel[bot]
Preview – cap-status — c08865cc Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant