Repository navigation
fix(extension): keep upload progress tied to its recording - #3499
Merged
Merged
Conversation
Contributor
|
@AksharP5 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
hey @greptileai, please re-review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An older recording's upload page could lose its Retry and Download controls when another recording started. It could also show the other recording's share link.
Ignore status updates that do not match the video ID in the page URL. The shared renderer covers broadcasts, storage updates and polling; matching-recording progress and completion continue normally. Intentional navigation by the service worker is unchanged.
Three regressions fail on the baseline and pass with the fix; the matching-recording control passes in both. All 43 extension tests pass using the repository HTML and actual upload module with Chrome boundary fixtures. Explicit jsdom test dependencies reuse existing locked versions; no resolved package versions changed.
Package typecheck and all production builds pass. Independent GPT-6 Astra HIGH review passed all 43 tests plus seven additional identity/retry probes, reproduced baseline failures, and verified the frozen install. Tests do not mount a Chrome extension or perform live uploads. Reloading an old A page after global state has already moved to B does not restore historical progress; this patch prevents it from displaying B's state.
Closes #3498.


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
The upload page now ignores status updates for other recordings.
Reviews (2) · Last reviewed commit: "Merge branch 'main' into upload-page-ide..." · Reviewed by Greptile