Repository navigation
Conversation
Contributor
|
Someone is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Author
|
@greptile-apps please re-review. Addressed the open P1/P2 items in the latest push on this branch. |
AatmanAJ
force-pushed
the
perf/render-shaders-overlay
branch
from
October 30, 2026 00:26
6a36f76 to
a9a4198
Compare
Contributor
Author
|
@greptile-apps review |
2 similar comments
Contributor
Author
|
@greptile-apps review |
Contributor
Author
|
@greptile-apps review |
Member
|
Thanks! Can you rebase on main to clear the conflicts and resolve the open review threads? Then we'll take a look. |
added 8 commits
November 4, 2026 17:27
Motion-blur taps use a single texture read instead of sharpened downscale sampling; overlay backdrops refresh less often when crop and display size are stable; cropped D3D capture frames reuse a texture pool so queued frames are not overwritten.
Refactoring for blur sampling moved crop clamping into cropped_sample_uv but left sample_texture using safe_min/safe_max out of scope.
Hold the scap Direct3D frame until the encoder finishes processing the texture so pooled crop surfaces are not recycled early.
…and stop reading a private field
…set bitrate At 80 kbps the paravirtualised VideoToolbox HEVC encoder on the CI macOS VMs occasionally left a blurred camera code cell at margin 0.17, below the reader's 0.18 threshold. 138,240 bps is the Web export preset (0.08 bpp), still below the Social preset the verify exports use.
AatmanAJ
force-pushed
the
perf/render-shaders-overlay
branch
from
November 4, 2026 17:47
0c28d46 to
b3c3155
Compare
Contributor
Author
|
@greptile-apps review |
…ted with Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@greptile-apps review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
composite-video-frame.wgslusessample_texture_blur(singletextureSampleper tap) instead of the sharpened 5-tap downscale path used for the main composite sample.TrimPool) per frame so in-flight frames are not overwritten by the next crop copy.Deferred
CAP_MUXER_BUFFER_SIZEknob (default 240) remains the primary backpressure lever; a dedicated GPU encode staging ring is left for a follow-up.Test plan
The PR appears safe to merge, with no new actionable issues found.Summary
The PR reduces motion-blur sampling work, spaces out picker backdrop captures, and pools cropped Windows capture textures.
Reviews (7) · Last reviewed commit: "fix(desktop-gpui): tie a backdrop captur..." · Reviewed by Greptile