Repository navigation
Conversation
Contributor
|
Someone is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Comments Outside DiffThese findings could not be posted inline.
|
AatmanAJ
force-pushed
the
perf/editor-preview-pipeline
branch
from
October 30, 2026 00:26
34abbf8 to
a11789f
Compare
Contributor
Author
|
@greptile-apps review |
2 similar comments
Contributor
Author
|
@greptile-apps review |
Contributor
Author
|
@greptile-apps review |
Member
|
Thanks! Can you rebase on main to clear the conflicts and resolve the open review threads? Then we'll take a look. |
added 7 commits
November 4, 2026 17:28
Overlap GPU BGRA readback with rendering during realtime playback, use GPU BGRA on capable adapters, and stream preview frames into a reused texture on Windows/Linux to avoid per-frame CPU swizzle and atlas uploads.
Double-buffer BGRA GPU readbacks, wait for map callbacks reliably, and flush pipelined frames before seek/immediate renders.
The PR deleted mapped_result but PendingReadback::map still called it, so cap-rendering did not compile. Restore it, its test, and its use in the NV12 readback so a callback another renderer is about to run on a shared device is still waited for.
Pipelined submits must alternate buffers: with a single slot wgpu rejects the second copy with 'Buffer is still mapped'. The new tests drive eight pipelined frames and a discarded pending readback through the two-slot ring and compare every pixel.
…nd drain the last one - pair each delivered frame with the layout it was rendered with instead of the current request's - stop discarding the pending frame when a newer request replaces it, which starved the preview under sustained backlog - discard the pending frame before seeks, paused redraws and thumbnails so they get their own frame - deliver the pending frame when playback ends - keep BGRA transition renders pipelined like RGBA ones and add an immediate variant - cover the new Bgra output in the imported-music benchmark
…set bitrate At 80 kbps the paravirtualised VideoToolbox HEVC encoder on the CI macOS VMs occasionally left a blurred camera code cell at margin 0.17, below the reader's 0.18 threshold. 138,240 bps is the Web export preset (0.08 bpp), still below the Social preset the verify exports use.
AatmanAJ
force-pushed
the
perf/editor-preview-pipeline
branch
from
November 4, 2026 17:51
247ed79 to
bfcdd9b
Compare
Contributor
Author
|
@greptile-apps review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamingImageon Windows/Linux by default to reuse one texture per stream and skip per-frame atlas uploads (disable withCAP_GPUI_STREAMING_IMAGE=0).Test plan
CAP_GPUI_STREAMING_IMAGE=0: preview falls back toRenderImageconversion path.
The PR appears safe to merge; no new actionable issue was found.Summary
The PR pipelines editor preview readback and enables reusable preview textures on Windows and Linux.
Static review found no new actionable issues. No build, native playback test, or visual capture was run.
Reviews (5) · Last reviewed commit: "fix(ci): walk GIF blocks when measuring ..." · Reviewed by Greptile