Skip to content

fix(desktop-gpui): expect no picker backdrop where Windows skips it on purpose - #3707

Merged
richiemcilroy merged 1 commit into
mainfrom
fix/picker-smoke-windows-backdrop
Nov 4, 2026
Merged

richiemcilroy merged 1 commit into
mainfrom
fix/picker-smoke-windows-backdrop

Conversation

@richiemcilroy

@richiemcilroy richiemcilroy commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Picker smoke (Windows) has failed on every PR since #3525. That PR stopped the Windows display and window pickers from capturing the desktop under their glass. The probe still required that capture in every mode, so it reported "backdrop": {"present": false, "passed": false} for display and window, and the run failed.

The probe now asks the overlay's own backdrop_suits whether the mode should have a backdrop. Where it shouldn't, the check passes only if no backdrop is present, so a capture coming back on Windows would still fail it. Other modes and platforms keep the existing check: a backdrop must be present and differ from the screenshot.

From the last failing run on main (run 41740365160), every other picker check passed:

Mode Backdrop before Expected now
display absent, failed absent, passes
window absent, failed absent, passes
area present, mean difference 54.8, passed unchanged

backdrop_suits becomes pub(crate) so the probe can use it. No app behaviour changes.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

The picker probe now follows the overlay’s existing backdrop policy.

  • Picker smoke checks follow the overlay’s backdrop expectations.

No actionable issues found. Review used source inspection; no runtime checks were run.

Reviews (1) · Last reviewed commit: "fix(desktop-gpui): expect no picker back..." · Reviewed by Greptile

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

Open in Capy

@richiemcilroy
richiemcilroy merged commit 81ef0e4 into main Nov 4, 2026
58 checks passed

This branch was previously deployed

1 inactive deployment
Preview – cap-status — 7144aa6d Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant