Repository navigation
fix(desktop-gpui): expect no picker backdrop where Windows skips it on purpose - #3707
Merged
Merged
Conversation
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picker smoke (Windows)has failed on every PR since #3525. That PR stopped the Windows display and window pickers from capturing the desktop under their glass. The probe still required that capture in every mode, so it reported"backdrop": {"present": false, "passed": false}for display and window, and the run failed.The probe now asks the overlay's own
backdrop_suitswhether the mode should have a backdrop. Where it shouldn't, the check passes only if no backdrop is present, so a capture coming back on Windows would still fail it. Other modes and platforms keep the existing check: a backdrop must be present and differ from the screenshot.From the last failing run on main (run 41740365160), every other picker check passed:
backdrop_suitsbecomespub(crate)so the probe can use it. No app behaviour changes.

Confidence Score: 5/5
The PR appears safe to merge.Summary
The picker probe now follows the overlay’s existing backdrop policy.
No actionable issues found. Review used source inspection; no runtime checks were run.
Reviews (1) · Last reviewed commit: "fix(desktop-gpui): expect no picker back..." · Reviewed by Greptile