You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[repo] removed saving artifacts with test logs to avoid leaking secrets - #3247
Saving logs as downloadable artifacts is unsafe even only organization has access to it. Especially for cloud tests. This PR resolves it in next way
removes saving any test related artifacts. Non cloud tests can be troubleshooted locally
move cloud tests out of PR verification and make them run daily. Currently we to not block PR merge because of failing cloud tests
removes JWT tests as they create short-living credential to access cloud instance.
Note
Medium Risk
CI coverage and failure-debugging change (no report artifacts; cloud no longer on every PR), with reduced JWT/cloud auth testing in the main pipeline.
Overview
Stops publishing Surefire/Failsafe report artifacts from CI workflows (build.yml, jvm-compatibility.yml, test_head.yml) and drops the compile job’s JDBC artifact upload, so failed runs are less likely to expose secrets in downloadable logs.
ClickHouse Cloud integration is removed from the PR Build workflow and moved to a new Cloud Tests workflow (.github/workflows/cloud.yml) on a daily cron plus manual dispatch, so cloud failures no longer gate merges. That split also removes the Python JWT helper/scripts and the cloud-only testJWTWithCloud integration tests; cloud runs now use password auth like the rest of the suite.
Mock bearer-token tests in client and JDBC now skip on cloud and cluster runs instead of silently no-op’ing on cloud only.
Reviewed by Cursor Bugbot for commit ed06345. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Saving logs as downloadable artifacts is unsafe even only organization has access to it. Especially for cloud tests. This PR resolves it in next way
Note
Medium Risk
CI coverage and failure-debugging change (no report artifacts; cloud no longer on every PR), with reduced JWT/cloud auth testing in the main pipeline.
Overview
Stops publishing Surefire/Failsafe report artifacts from CI workflows (
build.yml,jvm-compatibility.yml,test_head.yml) and drops the compile job’s JDBC artifact upload, so failed runs are less likely to expose secrets in downloadable logs.ClickHouse Cloud integration is removed from the PR Build workflow and moved to a new Cloud Tests workflow (
.github/workflows/cloud.yml) on a daily cron plus manual dispatch, so cloud failures no longer gate merges. That split also removes the Python JWT helper/scripts and the cloud-onlytestJWTWithCloudintegration tests; cloud runs now use password auth like the rest of the suite.Mock bearer-token tests in client and JDBC now skip on cloud and cluster runs instead of silently no-op’ing on cloud only.
Reviewed by Cursor Bugbot for commit ed06345. Bugbot is set up for automated code reviews on this repo. Configure here.