Skip to content

fix(exec-harness): compile node analysis workloads eagerly with sparkplug - #595

Open
not-matthias wants to merge 1 commit into
mainfrom
cod-3936-exec-harness-always-sparkplug-node-analysis-flags
Open

not-matthias wants to merge 1 commit into
mainfrom
cod-3936-exec-harness-always-sparkplug-node-analysis-flags

Conversation

@not-matthias

Copy link
Copy Markdown
Member

Add --always-sparkplug to the Node.js analysis flags in the codspeed exec wrapper, matching getV8Flags() in CodSpeedHQ/codspeed-node#104.

Merge together with or after CodSpeedHQ/codspeed-node#104, so codspeed exec and plugin-driven runs keep using the same flags.

…plug

Mirror the codspeed-node analysis V8 flags so codspeed exec and plugin-driven runs use the same compilation settings.
@greptile-apps

greptile-apps Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge with the stated merge order for codspeed-node#104.

Summary

Adds --always-sparkplug to Node.js analysis runs so V8 compiles workloads eagerly.

  • Analysis-mode Node.js runs now request eager Sparkplug compilation.

not-matthias explicitly acknowledged the temporary difference from codspeed-node and required merging together with or after codspeed-node#104.

Reviews (1) · Last reviewed commit: "fix(exec-harness): compile node analysis..." · Reviewed by Greptile

@codspeed

codspeed Bot commented Oct 26, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 8 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 41 untouched benchmarks
⏩ 6 skipped benchmarks1


Comparing cod-3936-exec-harness-always-sparkplug-node-analysis-flags (5b73b88) with main (d9612e3)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant