Repository navigation
Manchester | 26-SDC-Jun | Fithi Teklom | Sprint 2 | Improve code with Precomputing - #265
Open
Fithi-Teklom wants to merge 3 commits into
Open
Fithi-Teklom wants to merge 3 commits into
Fithi-Teklom wants to merge 3 commits into
Conversation
Fithi-Teklom
added
the
Needs Review
cjyuan
reviewed
Oct 21, 2026
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you use complexity to explain how the new implementation is better than the original implementation?
cjyuan
added
Reviewed
Fithi-Teklom
added
Needs Review
cjyuan
removed
the
Needs Review
cjyuan
reviewed
Oct 21, 2026
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Analyses look good.
Note: With complexity analysis, we should also describe what
cjyuan
added
the
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1183
Changelist
Improve the codes with precomputing.